Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented optional (presented) fields for proto3 #770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

biosvs
Copy link

@biosvs biosvs commented Jul 27, 2023

Ofc this PR will never be merged.

Although if you stuck with gogo, need "presence" feature, and brave enough..

(Added some fields to descriptor.proto manually. Didn't fix some tests - they are broken due to protoc version upgrade; didn't add new tests.)

fix #713

@nightwolfz
Copy link

Thanks

@bwplotka
Copy link

bwplotka commented Feb 5, 2024

Thanks!

We consider using this until we get migrate out of gogoproto in Prometheus EDIT: Actually we decided to skip optional, it's too dangerous, even mentioned in the official Google Cloud docs 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for proto3 field presence
3 participants