Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin versions for dependencies in Makefile #721

Closed
wants to merge 1 commit into from

Conversation

nikhita
Copy link

@nikhita nikhita commented Jan 27, 2021

The indirect dependencies in go.mod, specifically golang.org/x/tools and github.com/kisielk/errcheck, are not really used anywhere in the code. go mod tidy also removes these lines. They are only used in the Makefile using go get.

Currently, no version is specified while using go get. This means that go will try to fetch the latest version and this version can deviate from the version in go.mod. To avoid this, the PR updates the Makefile to explicitly go get the versions specified in go.mod.

Additionally, this PR also updates the versions to match the versions in v1.3.1 i.e. avoids the version bumps made in #717:

Context - bumping gogo/protobuf from v1.3.1 to v1.3.2 in kubernetes requires bumping x/tools as well, which we'd like to avoid in k8s (xref kubernetes/client-go#927)

cc @awalterschulze

@nikhita
Copy link
Author

nikhita commented Jan 27, 2021

fyi @dims @palnabarun

@awalterschulze
Copy link
Member

I guess because it is used in CI and I am not familiar with godeps, it is after my time in go land.
Also see #691
Unfortunately we do not have personal capacity to keep on maintaining this project.

@nikhita nikhita force-pushed the golang/x/tools branch 2 times, most recently from c9b6a48 to 78d05e3 Compare January 27, 2021 09:26
@nikhita nikhita changed the title Remove golang.org/x/tools from go.mod Pin versions for dependencies in Makefile Jan 27, 2021
@nikhita nikhita closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants