Fix buffer reuse #624
Closed
Fix buffer reuse #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I would have to regenerate the pb.go test files |
…en a proto.Buffer and proto.Marshal with different proto.Buffer sizes.
apelisse
force-pushed
the
fix-buffer-reuse
branch
from
d0d6954
to
06b3fdc
Compare
|
OK This should be working now, I've undid the changes that I had done to XXX_Marshal, and used a different interface instead, I think this should be good. |
jmarais
reviewed
Sep 17, 2019
| } | ||
|
|
||
| } | ||
| if m, ok := pb.(reverseMarshaler); ok { |
There was a problem hiding this comment.
Currently I think I would prefer too rather not adding another interface here and keep calling the XXX methods here.
With the direct calling we will skip the p.deterministic setting on the buffer.
There was a problem hiding this comment.
I do have a safer approach here:
#627
Keeping the current interfaces/flow.
|
In favor of: #627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix to issue #619. I've used the test built in #621. Not sure which one is best.