Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flock: our second project! #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

adamdecaf
Copy link
Member

@adamdecaf adamdecaf commented Sep 30, 2018

I noticed it wasn't listed today, so I threw something together. Figure it's good press for the projects too!

Fixes: #2

Copy link
Member

@theckman theckman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, with one piece of feedback about the second section. How do you feel about it?


Our second project to adopt was [flock](https://github.com/gofrs/flock) (formerly known as `github.com/theckman/go-flock`). This project was donated to us from [@theckman](https://github.com/theckman) and we hapily adopted it because of its use in some projects across the community.

Overall, the project seems stable and complete. There aren't a tons and tons of users, but some important projects. ([Import list](https://godoc.org/github.com/theckman/go-flock?importers))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would combine these two sentences:

Based on its issue and PR history the project seems stable and complete, with some impactful projects making use of it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that reads much better.

Copy link
Member

@niaow niaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamdecaf
Copy link
Member Author

cc @theckman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants