Fix CI badge link #121
Fix CI badge link #121
Conversation
|
@dylan-bourque If you have time, could you review my PR? |
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| # UUID | |||
|
|
|||
| [](https://github.com/gofrs/uuid/blob/master/LICENSE) | |||
| [](https://travis-ci.org/gofrs/uuid) | |||
| [](https://github.com/gofrs/uuid/actions/workflows/go.yml) | |||
There was a problem hiding this comment.
The link update is 👍 but I would probably leave the label set to "Build Status"
There was a problem hiding this comment.
@dylan-bourque This label depends on the name of the GitHub Actions, so if we want it to be Build, we'll need to change name field in go.yml.
https://github.com/gofrs/uuid/blob/master/.github/workflows/go.yml#L1
There was a problem hiding this comment.
The alt text for the image in the Markdown has to match the name of the workflow? That doesn't make sense and it's not called out that way in the docs anywhere that I can find.
There was a problem hiding this comment.
The alt text one, that's ok, I mistook it for the label shown on the badge.
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| # UUID | |||
|
|
|||
| [](https://github.com/gofrs/uuid/blob/master/LICENSE) | |||
| [](https://travis-ci.org/gofrs/uuid) | |||
| [](https://github.com/gofrs/uuid/actions/workflows/go.yml) | |||
| [](http://godoc.org/github.com/gofrs/uuid) | |||
There was a problem hiding this comment.
As long as you're cleaning up this README, would you mind updating this link to point to pkg.go.dev?
There was a problem hiding this comment.
OK, I'll change it.
|
Thank you very much for catching this mistake and fixing it @osamingo ! |
SSIA