Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(whats_new.md): CORS middleware #2979

Merged
merged 2 commits into from Apr 25, 2024

Conversation

sixcolors
Copy link
Member

@sixcolors sixcolors commented Apr 23, 2024

This pull request updates the whats_new.md with changes to the CORS middleware Config struct. The migration guide in the description provides an example of how to update the code.

Summary by CodeRabbit

  • Documentation
    • Updated the CORS middleware configuration details in the "What's New" section to reflect recent changes.

@sixcolors sixcolors requested a review from a team as a code owner April 23, 2024 13:22
@sixcolors sixcolors requested review from gaby, ReneWerner87 and efectn and removed request for a team April 23, 2024 13:22
Copy link
Contributor

coderabbitai bot commented Apr 23, 2024

Walkthrough

The recent update in the Fiber app enhances the CORS middleware by transitioning key fields like AllowOrigins, AllowMethods, AllowHeaders, and ExposeHeaders from string to slice types. This change simplifies configuration management for CORS handling, offering increased flexibility in defining policies.

Changes

File Path Change Summary
docs/whats_new.md Updated CORS middleware to use slice types for key fields

Poem

🌟🐇 A tweak so fine, in Fiber's domain,
Strings to slices, a CORS gain.
Configs now dance, with slices so fleet,
Code evolves, oh what a treat!
🎉🌱 Cheers to changes, in every byte,
As we code on, in the rabbit's light!


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between e0f0279 and f2f5b00.
Files selected for processing (1)
  • docs/whats_new.md (1 hunks)
Additional Context Used
LanguageTool (116)
docs/whats_new.md (116)

Near line 8: “its” (belonging to it) seems less likely than “it’s” (it is)
Context: ...v3 sidebar_position: 2 --- :::caution Its a draft, not finished yet. ::: [//]: ...


Near line 19: The phrase ‘a lot of’ might be wordy and overused. Consider using an alternative.
Context: ...3! 🚀 Fiber v3 is a major release with a lot of new features, improvements, and breakin...


Near line 31: Do you wish to insert an arrow?
Context: ... to the Fiber app, including: * Listen -> unified with config * app.Config proper...


Near line 32: It looks like there is a word missing here. Did you mean “listen to config”?
Context: ...config * app.Config properties moved to listen config * DisableStartupMessage * EnablePre...


Near line 33: Possible spelling mistake found.
Context: ...g properties moved to listen config * DisableStartupMessage * EnablePrefork -> previously Prefork...


Near line 34: Possible spelling mistake found.
Context: ...en config * DisableStartupMessage * EnablePrefork -> previously Prefork * EnablePrintRo...


Near line 34: Do you wish to insert an arrow?
Context: ...DisableStartupMessage * EnablePrefork -> previously Prefork * EnablePrintRoute...


Near line 34: Possible spelling mistake found.
Context: ...Message * EnablePrefork -> previously Prefork * EnablePrintRoutes * ListenerNetwo...


Near line 35: Possible spelling mistake found.
Context: ...EnablePrefork -> previously Prefork * EnablePrintRoutes * ListenerNetwork -> previously Netwo...


Near line 36: Possible spelling mistake found.
Context: ...ously Prefork * EnablePrintRoutes * ListenerNetwork -> previously Network #### new methods...


Near line 36: Do you wish to insert an arrow?
Context: ...* EnablePrintRoutes * ListenerNetwork -> previously Network #### new methods *...


Near line 36: This adverb was used twice in the sentence. Consider removing one of them or replacing them with a synonym.
Context: ...nablePrintRoutes * ListenerNetwork -> previously Network #### new methods * RegisterCu...


Near line 40: Possible spelling mistake found.
Context: ...previously Network #### new methods * RegisterCustomBinder * RegisterCustomConstraint * NewCtxFunc...


Near line 41: Possible spelling mistake found.
Context: ...# new methods * RegisterCustomBinder * RegisterCustomConstraint * NewCtxFunc #### removed methods * M...


Near line 42: Possible spelling mistake found.
Context: ...stomBinder * RegisterCustomConstraint * NewCtxFunc #### removed methods * Mount -> Use a...


Near line 46: Do you wish to insert an arrow?
Context: ...wCtxFunc #### removed methods * Mount -> Use app.Use() instead * ListenTLS -> Us...


Near line 47: Possible spelling mistake found.
Context: ...ods * Mount -> Use app.Use() instead * ListenTLS -> Use app.Listen() with tls.Config * L...


Near line 47: Do you wish to insert an arrow?
Context: ...nt -> Use app.Use() instead * ListenTLS -> Use app.Listen() with tls.Config * List...


Near line 47: Possible spelling mistake found.
Context: ...ad * ListenTLS -> Use app.Listen() with tls.Config * ListenTLSWithCertificate -> Us...


Near line 47: Add a space between sentences.
Context: ... ListenTLS -> Use app.Listen() with tls.Config * ListenTLSWithCertificate -> Use app.L...


Near line 48: Possible spelling mistake found.
Context: ...S -> Use app.Listen() with tls.Config * ListenTLSWithCertificate -> Use app.Listen() with tls.Config * L...


Near line 48: Do you wish to insert an arrow?
Context: ...h tls.Config * ListenTLSWithCertificate -> Use app.Listen() with tls.Config * List...


Near line 48: Possible spelling mistake found.
Context: ...ithCertificate -> Use app.Listen() with tls.Config * ListenMutualTLS -> Use app.Lis...


Near line 48: Add a space between sentences.
Context: ...ertificate -> Use app.Listen() with tls.Config * ListenMutualTLS -> Use app.Listen() w...


Near line 49: Possible spelling mistake found.
Context: ...e -> Use app.Listen() with tls.Config * ListenMutualTLS -> Use app.Listen() with tls.Config * L...


Near line 49: Do you wish to insert an arrow?
Context: ...ten() with tls.Config * ListenMutualTLS -> Use app.Listen() with tls.Config * List...


Near line 49: Possible spelling mistake found.
Context: ...istenMutualTLS -> Use app.Listen() with tls.Config * ListenMutualTLSWithCertificate...


Near line 49: Add a space between sentences.
Context: ...nMutualTLS -> Use app.Listen() with tls.Config * ListenMutualTLSWithCertificate -> Use...


Near line 50: Possible spelling mistake found.
Context: ...S -> Use app.Listen() with tls.Config * ListenMutualTLSWithCertificate -> Use app.Listen() with tls.Config ##...


Near line 50: Do you wish to insert an arrow?
Context: ...Config * ListenMutualTLSWithCertificate -> Use app.Listen() with tls.Config #### ...


Near line 50: Possible spelling mistake found.
Context: ...ithCertificate -> Use app.Listen() with tls.Config #### changed methods * Routing...


Near line 50: Add a space between sentences.
Context: ...ertificate -> Use app.Listen() with tls.Config #### changed methods * Routing method...


Near line 54: Do you wish to insert an arrow?
Context: ...#### changed methods * Routing methods -> Get(), Post(), Put(), Delete(), Patch()...


Near line 55: Do you wish to insert an arrow?
Context: ...s(), Trace(), Connect() and All() * Use -> can be used for app mounting * Test -> ...


Near line 56: Do you wish to insert an arrow?
Context: ... -> can be used for app mounting * Test -> timeout changed to 1 second * Listen ->...


Near line 57: Do you wish to insert an arrow?
Context: ...-> timeout changed to 1 second * Listen -> has a config parameter * Listener -> ha...


Near line 58: Do you wish to insert an arrow?
Context: ...en -> has a config parameter * Listener -> has a config parameter ### Context cha...


Near line 66: Possible spelling mistake found.
Context: ... #### customizable #### new methods * AutoFormat -> ExpressJs like * Host -> ExpressJs l...


Near line 66: Do you wish to insert an arrow?
Context: ...mizable #### new methods * AutoFormat -> ExpressJs like * Host -> ExpressJs like...


Near line 66: The official spelling of this programming framework is “Express.js”.
Context: ...able #### new methods * AutoFormat -> ExpressJs like * Host -> ExpressJs like * Port ->...


Near line 67: Do you wish to insert an arrow?
Context: ... * AutoFormat -> ExpressJs like * Host -> ExpressJs like * Port -> ExpressJs like...


Near line 67: The official spelling of this programming framework is “Express.js”.
Context: ... AutoFormat -> ExpressJs like * Host -> ExpressJs like * Port -> ExpressJs like * IsProxy...


Near line 68: Do you wish to insert an arrow?
Context: ...Js like * Host -> ExpressJs like * Port -> ExpressJs like * IsProxyTrusted * Reset...


Near line 68: The official spelling of this programming framework is “Express.js”.
Context: ...like * Host -> ExpressJs like * Port -> ExpressJs like * IsProxyTrusted * Reset * Schema ...


Near line 69: Possible spelling mistake found.
Context: ...pressJs like * Port -> ExpressJs like * IsProxyTrusted * Reset * Schema -> ExpressJs like * Se...


Near line 71: Do you wish to insert an arrow?
Context: ... like * IsProxyTrusted * Reset * Schema -> ExpressJs like * SendStream -> ExpressJ...


Near line 71: The official spelling of this programming framework is “Express.js”.
Context: ...ke * IsProxyTrusted * Reset * Schema -> ExpressJs like * SendStream -> ExpressJs like * S...


Near line 72: Possible spelling mistake found.
Context: ...ed * Reset * Schema -> ExpressJs like * SendStream -> ExpressJs like * SendString -> Expre...


Near line 72: Do you wish to insert an arrow?
Context: ...* Schema -> ExpressJs like * SendStream -> ExpressJs like * SendString -> ExpressJ...


Near line 72: The official spelling of this programming framework is “Express.js”.
Context: ...chema -> ExpressJs like * SendStream -> ExpressJs like * SendString -> ExpressJs like * S...


Near line 73: Possible spelling mistake found.
Context: ...s like * SendStream -> ExpressJs like * SendString -> ExpressJs like * String -> ExpressJs...


Near line 73: Do you wish to insert an arrow?
Context: ...ndStream -> ExpressJs like * SendString -> ExpressJs like * String -> ExpressJs li...


Near line 73: The official spelling of this programming framework is “Express.js”.
Context: ...tream -> ExpressJs like * SendString -> ExpressJs like * String -> ExpressJs like * ViewB...


Near line 74: Do you wish to insert an arrow?
Context: ...* SendString -> ExpressJs like * String -> ExpressJs like * ViewBind -> instead of...


Near line 74: The official spelling of this programming framework is “Express.js”.
Context: ...endString -> ExpressJs like * String -> ExpressJs like * ViewBind -> instead of Bind ###...


Near line 75: Possible spelling mistake found.
Context: ...essJs like * String -> ExpressJs like * ViewBind -> instead of Bind #### removed method...


Near line 75: Do you wish to insert an arrow?
Context: ...e * String -> ExpressJs like * ViewBind -> instead of Bind #### removed methods ...


Near line 79: Possible spelling mistake found.
Context: ...nstead of Bind #### removed methods * AllParams -> c.Bind().URL() ? * ParamsInt -> Para...


Near line 79: Do you wish to insert an arrow?
Context: ...Bind #### removed methods * AllParams -> c.Bind().URL() ? * ParamsInt -> Params ...


Near line 79: Add a space between sentences.
Context: ... #### removed methods * AllParams -> c.Bind().URL() ? * ParamsInt -> Params Generic...


Near line 79: Do not use a space before the final punctuation mark.
Context: ...ed methods * AllParams -> c.Bind().URL() ? * ParamsInt -> Params Generic * QueryBo...


Near line 80: Possible spelling mistake found.
Context: ...hods * AllParams -> c.Bind().URL() ? * ParamsInt -> Params Generic * QueryBool -> Query ...


Near line 80: Do you wish to insert an arrow?
Context: ...lParams -> c.Bind().URL() ? * ParamsInt -> Params Generic * QueryBool -> Query Gen...


Near line 80: Possible spelling mistake found.
Context: ...rams -> c.Bind().URL() ? * ParamsInt -> Params Generic * QueryBool -> Query Generic * ...


Near line 81: Possible spelling mistake found.
Context: ...URL() ? * ParamsInt -> Params Generic * QueryBool -> Query Generic * QueryFloat -> Query ...


Near line 81: Do you wish to insert an arrow?
Context: ...ParamsInt -> Params Generic * QueryBool -> Query Generic * QueryFloat -> Query Gen...


Near line 82: Possible spelling mistake found.
Context: ... Generic * QueryBool -> Query Generic * QueryFloat -> Query Generic * QueryInt -> Query Ge...


Near line 82: Do you wish to insert an arrow?
Context: ...QueryBool -> Query Generic * QueryFloat -> Query Generic * QueryInt -> Query Gener...


Near line 83: Possible spelling mistake found.
Context: ...Generic * QueryFloat -> Query Generic * QueryInt -> Query Generic * BodyParser -> c.Bind...


Near line 83: Do you wish to insert an arrow?
Context: ... QueryFloat -> Query Generic * QueryInt -> Query Generic * BodyParser -> c.Bind()....


Near line 84: Possible spelling mistake found.
Context: ...y Generic * QueryInt -> Query Generic * BodyParser -> c.Bind().Body() * CookieParser -> c....


Near line 84: Do you wish to insert an arrow?
Context: ... QueryInt -> Query Generic * BodyParser -> c.Bind().Body() * CookieParser -> c.Bin...


Near line 84: Add a space between sentences.
Context: ...yInt -> Query Generic * BodyParser -> c.Bind().Body() * CookieParser -> c.Bind().Coo...


Near line 84: Add a space between sentences.
Context: ... Query Generic * BodyParser -> c.Bind().Body() * CookieParser -> c.Bind().Cookie() *...


Near line 85: Possible spelling mistake found.
Context: ...neric * BodyParser -> c.Bind().Body() * CookieParser -> c.Bind().Cookie() * ParamsParser -> ...


Near line 85: Do you wish to insert an arrow?
Context: ...arser -> c.Bind().Body() * CookieParser -> c.Bind().Cookie() * ParamsParser -> c.B...


Near line 85: Add a space between sentences.
Context: ... -> c.Bind().Body() * CookieParser -> c.Bind().Cookie() * ParamsParser -> c.Bind().U...


Near line 85: Add a space between sentences.
Context: ...ind().Body() * CookieParser -> c.Bind().Cookie() * ParamsParser -> c.Bind().URL() * Re...


Near line 86: Possible spelling mistake found.
Context: ...) * CookieParser -> c.Bind().Cookie() * ParamsParser -> c.Bind().URL() * RedirectToRoute -> ...


Near line 86: Do you wish to insert an arrow?
Context: ...ser -> c.Bind().Cookie() * ParamsParser -> c.Bind().URL() * RedirectToRoute -> c.R...


Near line 86: Add a space between sentences.
Context: ...> c.Bind().Cookie() * ParamsParser -> c.Bind().URL() * RedirectToRoute -> c.Redirect...


Near line 87: Possible spelling mistake found.
Context: ...ie() * ParamsParser -> c.Bind().URL() * RedirectToRoute -> c.Redirect().Route() * RedirectBack ...


Near line 87: Do you wish to insert an arrow?
Context: ...ser -> c.Bind().URL() * RedirectToRoute -> c.Redirect().Route() * RedirectBack -> ...


Near line 87: Add a space between sentences.
Context: ...> c.Bind().URL() * RedirectToRoute -> c.Redirect().Route() * RedirectBack -> c.Redirect(...


Near line 87: Add a space between sentences.
Context: ...URL() * RedirectToRoute -> c.Redirect().Route() * RedirectBack -> c.Redirect().Back()...


Near line 88: Possible spelling mistake found.
Context: ...directToRoute -> c.Redirect().Route() * RedirectBack -> c.Redirect().Back() * ReqHeaderParse...


Near line 88: Do you wish to insert an arrow?
Context: ... -> c.Redirect().Route() * RedirectBack -> c.Redirect().Back() * ReqHeaderParser -...


Near line 88: Add a space between sentences.
Context: ....Redirect().Route() * RedirectBack -> c.Redirect().Back() * ReqHeaderParser -> c.Bind()....


Near line 88: Add a space between sentences.
Context: ....Route() * RedirectBack -> c.Redirect().Back() * ReqHeaderParser -> c.Bind().Header(...


Near line 89: Possible spelling mistake found.
Context: ...* RedirectBack -> c.Redirect().Back() * ReqHeaderParser -> c.Bind().Header() #### changed meth...


Near line 89: Do you wish to insert an arrow?
Context: ...> c.Redirect().Back() * ReqHeaderParser -> c.Bind().Header() #### changed methods...


Near line 89: Add a space between sentences.
Context: ...edirect().Back() * ReqHeaderParser -> c.Bind().Header() #### changed methods * Bin...


Near line 89: Add a space between sentences.
Context: ...().Back() * ReqHeaderParser -> c.Bind().Header() #### changed methods * Bind -> for ...


Near line 93: Do you wish to insert an arrow?
Context: ....Header() #### changed methods * Bind -> for Binding instead of View, us c.ViewB...


Near line 93: Only proper nouns start with an uppercase character (there are exceptions for headlines).
Context: ...() #### changed methods * Bind -> for Binding instead of View, us c.ViewBind() * Form...


Near line 93: Please check whether ‘is’ might be the correct word here instead of ‘us’.
Context: ... * Bind -> for Binding instead of View, us c.ViewBind() * Format -> Param: body in...


Near line 93: Add a space between sentences.
Context: ...nd -> for Binding instead of View, us c.ViewBind() * Format -> Param: body interface{} -...


Near line 94: Do you wish to insert an arrow?
Context: ...stead of View, us c.ViewBind() * Format -> Param: body interface{} -> handlers ......


Near line 94: Possible spelling mistake found.
Context: ...ad of View, us c.ViewBind() * Format -> Param: body interface{} -> handlers ...ResFmt...


Near line 94: Do you wish to insert an arrow?
Context: ...d() * Format -> Param: body interface{} -> handlers ...ResFmt * Redirect -> c.Redi...


Near line 94: Add a space between sentences.
Context: ... Param: body interface{} -> handlers ...ResFmt * Redirect -> c.Redirect().To() ### Cl...


Near line 95: Do you wish to insert an arrow?
Context: ...face{} -> handlers ...ResFmt * Redirect -> c.Redirect().To() ### Client package ...


Near line 95: Add a space between sentences.
Context: ...} -> handlers ...ResFmt * Redirect -> c.Redirect().To() ### Client package ### Bindin...


Near line 95: Add a space between sentences.
Context: ...rs ...ResFmt * Redirect -> c.Redirect().To() ### Client package ### Binding ###...


Near line 107: Consider rephrasing this to strengthen your wording.
Context: ... ### Updates to CORS Middleware We've made some changes to the CORS middleware to improve its f...


Near line 110: Possible spelling mistake found.
Context: ...from the Web Incubator Community Group (WICG). When set to true, the CORS middlewa...


Near line 115: Loose punctuation mark.
Context: ...updated fields: - Config.AllowOrigins: Now accepts a slice of strings, each re...


Near line 116: Loose punctuation mark.
Context: ... allowed origin. - Config.AllowMethods: Now accepts a slice of strings, each re...


Near line 117: Loose punctuation mark.
Context: ... allowed method. - Config.AllowHeaders: Now accepts a slice of strings, each re...


Near line 118: Loose punctuation mark.
Context: ...allowed header. - Config.ExposeHeaders: Now accepts a slice of strings, each re...


Near line 121: Possible spelling mistake found.
Context: ...d header. #### Session middleware #### Filesystem middleware ### Monitor middleware Moni...


Near line 124: Possible spelling mistake found.
Context: ...iddleware Monitor middleware is now in Contrib package. ## Migration guide ### CORS ...


Near line 130: Possible spelling mistake found.
Context: ...o use slices instead of strings for the AllowOrigins, AllowMethods, AllowHeaders, and `...


Near line 130: Possible spelling mistake found.
Context: ...tead of strings for the AllowOrigins, AllowMethods, AllowHeaders, and ExposeHeaders f...


Near line 130: Possible spelling mistake found.
Context: ...for the AllowOrigins, AllowMethods, AllowHeaders, and ExposeHeaders fields. Here's ho...


Near line 130: Possible spelling mistake found.
Context: ...s, AllowMethods, AllowHeaders, and ExposeHeaders` fields. Here's how you can update your...


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Out of diff range and nitpick comments (2)
docs/whats_new.md (2)

Line range hint 8-8: Correct the grammatical error in the caution note.

- Its a draft, not finished yet.
+ It's a draft, not finished yet.

Line range hint 19-19: Consider rephrasing to avoid wordiness.

Instead of "a lot of new features, improvements, and breaking changes," consider "numerous new features, enhancements, and significant changes."

docs/whats_new.md Outdated Show resolved Hide resolved
docs/whats_new.md Outdated Show resolved Hide resolved
docs/whats_new.md Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Out of diff range and nitpick comments (3)
docs/whats_new.md (3)

Line range hint 8-8: Correct the contraction in the caution note.

- Its a draft, not finished yet.
+ It's a draft, not finished yet.

Line range hint 19-19: Consider rephrasing "a lot of" to make the text more concise.

Consider using "numerous" or "many" instead of "a lot of" for a more formal tone.


107-107: Strengthen the wording in the introduction to the CORS middleware updates.

Consider using "Here are the enhancements to the CORS middleware:" to introduce the changes more assertively.

docs/whats_new.md Show resolved Hide resolved
docs/whats_new.md Show resolved Hide resolved
@ReneWerner87
Copy link
Member

Will check it tomorrow

@ReneWerner87 ReneWerner87 added this to the v3 milestone Apr 25, 2024
@ReneWerner87 ReneWerner87 merged commit 69f5b6b into gofiber:main Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants