Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running nilaway #2779

Closed
wants to merge 2 commits into from
Closed

Add support for running nilaway #2779

wants to merge 2 commits into from

Conversation

gaby
Copy link
Member

@gaby gaby commented Dec 29, 2023

Description

Add support for running nilaway during CI. This is a tool created by Uber that seeks to help developers avoid nil panics in production by catching them at compile time rather than runtime.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

@nickajacks1
Copy link
Member

This is awesome. Does it make sense to have the CI not check the pseudo-vendored internal packages?

@gaby
Copy link
Member Author

gaby commented Dec 29, 2023

@nickajacks1 It doesnt support excluding directories yet and has a lot of false positives. Thus why I have it as "Draft"

@gaby
Copy link
Member Author

gaby commented Jan 2, 2024

Closing for now, there's too many False positives. Will re-evaluate in the future.

@gaby gaby closed this Jan 2, 2024
@gaby gaby deleted the nilaway branch March 11, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants