Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializer refactoring #3

Closed
wants to merge 28 commits into from
Closed

Serializer refactoring #3

wants to merge 28 commits into from

Conversation

goetas
Copy link
Owner

@goetas goetas commented Jul 20, 2016

currently implemented (currently the existing test suite has been fixed and is still green):

Ideas (to do? ):

  • fix PSR
    • code style done
    • namespaces
  • remove some features (move to a different repo)
    • PHPCR driver (is it used by somebody?)
    • Doctine driver (is it used by somebody? can it be enabled by default? does it work good enough)
    • Propel
    • PhpCollection and phpoption done
    • remove xml driver? (i love xml... but looks that im alone)
  • visitors
    • make native types handled with listeners done (this creates 20-30 % of performance penality)
    • and make them treated in the same way as objects done
  • use symfony property access to read properties
  • allow to choose how to serialize arrays
    • as array
    • as object
    • skip if empty
  • remove handle callback feature done
  • graph navigator factory done
  • splitted graph navigator into serialize navigator and unserialize navigator done
  • converted type array into value object done

performance benchmark, this version is 20% slower 馃槩

schmittjoh and others added 3 commits May 21, 2016 14:25
If you want to make sure something is formatted as a list, i.e. ``[1, 2, 3]`` in JSON,
make sure to add an explicit type like ``@Type("array<integer>")``.

closes schmittjoh#571
closes schmittjoh#572
closes schmittjoh#488
closes schmittjoh#304

...and probably more
@goetas goetas changed the title Remove hndl Remove refactor Jul 21, 2016
@goetas goetas changed the title Remove refactor Serializer refactoring Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants