Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Godot methods for Quat #720

Merged
merged 8 commits into from Aug 23, 2021
Merged

Implement Godot methods for Quat #720

merged 8 commits into from Aug 23, 2021

Commits on Aug 7, 2021

  1. Implement Godot methods for Quat 

    There are still some tests lacking & `get_euler` has a large error for
some reason.
    @Demindiro
    Demindiro committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    bcf3f40 View commit details
    Browse the repository at this point in the history

  2. Incorporate feedback 

    * s/core::/std::
* Add documentation to IDENTITY constant
* s/get_euler/to_euler
* Use Basis::to_euler for to_euler instead. Incidentally, this fixes the
  precision issue in to_the euler test.
* Remove set_axis_angle and set_euler
* Make Basis::to_quat private. The implementation could perhaps be moved
  to Quat::from_basis instead?
    @Demindiro
    Demindiro committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    b863148 View commit details
    Browse the repository at this point in the history

  3. Add Basis::from_quat

    @Demindiro
    Demindiro committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    d1ac967 View commit details
    Browse the repository at this point in the history

  4. Add slerp and slerpni tests 

    The slerp test fails because the result diverges a lot. Using `slerp`
instead of `lerp` causes the result to be completely different.
    @Demindiro
    Demindiro committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    7ad7dba View commit details
    Browse the repository at this point in the history

  5. Copy Godot's Quat::slerp

    @Demindiro
    Demindiro committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    4bd3114 View commit details
    Browse the repository at this point in the history

  6. Add test for cubic_slerp

    @Demindiro
    Demindiro committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    1f27e29 View commit details
    Browse the repository at this point in the history

  7. Incorporate feedback, add Mul<Quat> for Quat

    @Demindiro
    Demindiro committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    c48eff9 View commit details
    Browse the repository at this point in the history

  8. Run cargo fmt

    @Demindiro
    Demindiro committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    32fd68f View commit details
    Browse the repository at this point in the history