Skip to content

Commit

Permalink
Merge #800
Browse files Browse the repository at this point in the history
800: Re-export `gdnative_core::log` again r=Bromeon a=chitoyuu

Types and functions in the `log` module should remain visible and part of the public API:

- `Site` is the return type of the trait method `Method::site`, and is necessary to name when implementing the trait manually e.g. for a generic method.
- `print`, `warn` and `error` are safe high-level bindings to the native logging facilities that aren't available elsewhere, and are worthwhile to expose for custom `log` backend implementations that want to use call site information from the logging framework instead.

Co-authored-by: Chitose Yuuzaki <chitoyuu@potatoes.gay>
  • Loading branch information
bors[bot] and chitoyuu committed Oct 19, 2021
2 parents e74c573 + adc6b2b commit 555cdcd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion gdnative-core/src/lib.rs
Expand Up @@ -45,7 +45,6 @@ pub mod core_types;
#[cfg(feature = "nativescript")]
pub mod nativescript;

#[doc(hidden)]
pub mod log;
pub mod object;

Expand Down
2 changes: 1 addition & 1 deletion gdnative/src/lib.rs
Expand Up @@ -58,7 +58,7 @@
// Items, which are #[doc(hidden)] in their original crate and re-exported with a wildcard, lose
// their hidden status. Re-exporting them manually and hiding the wildcard solves this.
#[doc(inline)]
pub use gdnative_core::{core_types, nativescript, object};
pub use gdnative_core::{core_types, log, nativescript, object};

/// Collection of declarative `godot_*` macros, mostly for GDNative registration and output.
pub mod macros {
Expand Down

0 comments on commit 555cdcd

Please sign in to comment.