Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Outdated API document as per issue #72 #73

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

jacobsky
Copy link
Contributor

@jacobsky jacobsky commented Jul 6, 2022

This should resolve issue #72 as well as better illustrate the options for getters and setters with Godot Rust

The code that is in the document has all been validated in my own test project.

@jacobsky jacobsky requested a review from Bromeon July 6, 2022 07:12
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🙂
Made some comments.

src/rust-binding/properties.md Outdated Show resolved Hide resolved
src/rust-binding/properties.md Outdated Show resolved Hide resolved
src/rust-binding/properties.md Outdated Show resolved Hide resolved
src/rust-binding/properties.md Outdated Show resolved Hide resolved
src/rust-binding/properties.md Show resolved Hide resolved
@Bromeon Bromeon merged commit 98a0eaa into godot-rust:master Jul 7, 2022
@Bromeon
Copy link
Member

Bromeon commented Jul 7, 2022

Thanks a lot! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants