New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serde support for GString, StringName, NodePath and Array #508
Conversation
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-508 |
1d28f6d
to
d30fc84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, great addition! 😊
I don't think the core should depend on a particular serde format, but rather just provide the traits. Could you remove the serde_json
dependency from godot-core
? It can stay in itest
.
From a file organization point of view, I think it could make sense to have a dedicated serde_test.rs
with all the new test cases. Then we'd only need one #[cfg]
on the outer module.
More than happy to contribute :)
godot-core should depends on The CI is not executing the If I remove I get:
|
But where is Dependencies in Btw, it looks like there's an issue with GitHub actions, your last commit didn't trigger the pipeline for some reason. Might be a downtime... |
3bcfc8d
to
2db0576
Compare
It's used in tests (not itest). Example: https://github.com/kuruk-mm/gdext/blob/master/godot-core/src/builtin/aabb.rs#L424-L431 I moved the I have just push-force the code with all you're reviews fixed. Edit: Last force push, I added license header for serde_tests.rs |
2db0576
to
b5af6a9
Compare
Oh, thanks a lot! It looks like CI doesn't cover that properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙂
I used godot-rust/gdnative#743 as a base PR, so thanks @lilizoey
I created some
itest
for testing these types.You can use locally with:
For executing tests, the CI needs to add the
serde
(notgodot/serde
) to the features on theitest
crate. If there is a better solution for this, please, let me know.