New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement simple img for SvgUri support #49

Open

jdmg94 wants to merge 1 commit into godaddy:master from jdmg94:master

jdmg94 commented Jan 19, 2020

fixes issue #48


          Implement simple img for SvgUri support

fb70c99

jdmg94 requested review from 3rd-Eden

January 19, 2020 19:03

coveralls commented Jan 19, 2020

Pull Request Test Coverage Report for Build 65

0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.2%) to 97.64%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
index.js	0	4	0.0%

Totals
Change from base Build 63:	-1.2%
Covered Lines:	255
Relevant Lines:	259

💛 - Coveralls

1 similar comment

coveralls commented Jan 19, 2020

Pull Request Test Coverage Report for Build 65

0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.2%) to 97.64%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
index.js	0	4	0.0%

Totals
Change from base Build 63:	-1.2%
Covered Lines:	255
Relevant Lines:	259

💛 - Coveralls

Contributor

3rd-Eden commented Jan 29, 2020

How would this be implemented for React-Native?

Author

jdmg94 commented Jan 29, 2020

@3rd-Eden you don’t, you just re-export it from react-native-svg like the rest of the native components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment