Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mockito-core from 4.5.1 to 4.6.0 #10479

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 30, 2022

Bumps mockito-core from 4.5.1 to 4.6.0.

Release notes

Sourced from mockito-core's releases.

v4.6.0

Changelog generated by Shipkit Changelog Gradle Plugin

4.6.0

Commits
  • 93bba11 Bump shipkit-changelog from 1.1.15 to 1.2.0 (#2654)
  • 70cf2d2 Add support for customizing strictness via @Mock annotation and `MockSettin...
  • 6ce278b Bump versions.errorprone from 2.13.1 to 2.14.0 (#2653)
  • 7d2e4cc Bump shipkit-auto-version from 1.1.20 to 1.2.0 (#2651)
  • d7a8ae0 Merge pull request #2645 from mockito/interface-annotations
  • a3d57fd Reintroduce inheriting type annotations from interfaces if only one interface...
  • 94e9797 Bump com.diffplug.spotless from 6.6.0 to 6.6.1 (#2643)
  • 0a7fb04 Fix reproducible build (#2642)
  • 4629ed8 Bump com.diffplug.spotless from 6.5.2 to 6.6.0 (#2641)
  • f59bf37 Bump material from 1.5.0 to 1.6.0 (#2637)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mockito-core](https://github.com/mockito/mockito) from 4.5.1 to 4.6.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v4.5.1...v4.6.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies java Pull requests that update Java code labels May 30, 2022
@chadlwilson chadlwilson added this to the Release 22.2.0 milestone May 30, 2022
@chadlwilson
Copy link
Member

chadlwilson commented May 30, 2022

Still investigating, but it looks like mockito/mockito#2650 might have changed the default for mocks created via mock(Blah.class to strict stubs, which is a problem in Groovy-land because we get errors like the below when trying to track the invocation everywhere (for some reason I need to dig more into - likely because tracking the invocations is not possible in same cases across the Groovy code - or maybe due to mockito-inline being present)

java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "org.mockito.invocation.Location.getSourceFile()" is null
        at org.mockito.internal.junit.DefaultStubbingLookupListener.potentialArgMismatches(DefaultStubbingLookupListener.java:81)
        at org.mockito.internal.junit.DefaultStubbingLookupListener.onStubbingLookup(DefaultStubbingLookupListener.java:52)
        at org.mockito.internal.listeners.StubbingLookupNotifier.notifyStubbedAnswerLookup(StubbingLookupNotifier.java:31)
        at org.mockito.internal.handler.MockHandlerImpl.handle(MockHandlerImpl.java:93)
        at org.mockito.internal.handler.NullResultGuardian.handle(NullResultGuardian.java:29)
        at org.mockito.internal.handler.InvocationNotifierHandler.handle(InvocationNotifierHandler.java:34)
...

@chadlwilson chadlwilson marked this pull request as draft May 30, 2022 06:08
@big-andy-coates
Copy link

I'm seeing similar. I've raised mockito/mockito#2656 to track. You may want to post your findings there.

@chadlwilson
Copy link
Member

Thanks @big-andy-coates, I have an issue drafted with a re-prod but not yet submitted. Was trying to get a demo project/code into a repo somewhere. Thanks for beating me to it!

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 31, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/org.mockito-mockito-core-4.6.0 branch May 31, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants