Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Treat empty nodes as zero values #415

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukemassa
Copy link

@lukemassa lukemassa commented Dec 29, 2023

Before submitting your PR, please confirm the following.

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

This code begins to address #414. Basically the idea is, "empty sequence entry" is not actually an "error" and should be treated as a "NullNode" instead.

There are still several additional issues code doesn't yet address, like:

Looking for confirmation that I've identified an actual issue and am on the right track to fix it, at which point I will continue trying to address and test for these additional cases.

@codecov-commenter
Copy link

Codecov Report

Merging #415 (28df8de) into master (0640a15) will decrease coverage by 0.06%.
The diff coverage is 78.57%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   76.02%   75.96%   -0.06%     
==========================================
  Files          13       13              
  Lines        4692     4694       +2     
==========================================
- Hits         3567     3566       -1     
- Misses        866      867       +1     
- Partials      259      261       +2     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants