feat: add option for missing field #398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DisallowMissingField option to create error when a field of a struct is missing. Remark: This solves the issue that the validator can't handle: when a int type is absent in the yaml, the validator has no way to find out as it checks against go structs.
goyzhang
force-pushed
the
feat/add-disallowmissingfield
branch
from
0036c30
to
8de587e
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 76.02% 76.10% +0.08%
==========================================
Files 13 13
Lines 4692 4708 +16
==========================================
+ Hits 3567 3583 +16
Misses 866 866
Partials 259 259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DisallowMissingField option to create error when a field of a struct is missing.
Remark:
This solves the issue that the validator can't handle: when a int type is absent in the yaml, the validator has no way to find out as it checks against go structs.
I would add this to
strict()but didn't, as it would cause a breaking change.see #397