Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply go fmt with Go 1.21 #394

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

shogo82148
Copy link
Contributor

go fmt now formats godoc comments.

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

@codecov-commenter
Copy link

Codecov Report

Merging #394 (926e2dd) into master (aa422f5) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   76.02%   76.02%           
=======================================
  Files          13       13           
  Lines        4692     4692           
=======================================
  Hits         3567     3567           
  Misses        866      866           
  Partials      259      259           

@goccy
Copy link
Owner

goccy commented Sep 15, 2023

If we use Go 1.21 based gofmt, I think that the go.mod version needs to be 1.21, not 1.19.

@shogo82148
Copy link
Contributor Author

With Go 1.19.13, I got same result.
So go.mod version don't need to be 1.21.

shogoichinose@Y0XKJ33CJW go-yaml % git switch apply-go-fmt-with-go1.21
Switched to branch 'apply-go-fmt-with-go1.21'
Your branch is up to date with 'origin/apply-go-fmt-with-go1.21'.
shogoichinose@Y0XKJ33CJW go-yaml % go1.19.13 fmt ./...
shogoichinose@Y0XKJ33CJW go-yaml % git status
On branch apply-go-fmt-with-go1.21
Your branch is up to date with 'origin/apply-go-fmt-with-go1.21'.

nothing to commit, working tree clean

@goccy
Copy link
Owner

goccy commented Sep 15, 2023

I see. I also tried gofmt with go1.19 and got the same result. So it wasn't a change from 1.21. LGTM 👍

@goccy goccy merged commit c33fec6 into goccy:master Sep 15, 2023
18 checks passed
renovate bot added a commit to anoriqq/qpm that referenced this pull request Sep 15, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/goccy/go-yaml](https://togithub.com/goccy/go-yaml) |
require | patch | `v1.11.1` -> `v1.11.2` |

---

### Release Notes

<details>
<summary>goccy/go-yaml (github.com/goccy/go-yaml)</summary>

###
[`v1.11.2`](https://togithub.com/goccy/go-yaml/releases/tag/v1.11.2):
1.11.2

[Compare
Source](https://togithub.com/goccy/go-yaml/compare/v1.11.1...v1.11.2)

#### What's Changed

- Fix handle of space at start or last by
[@&#8203;ozraru](https://togithub.com/ozraru) in
[goccy/go-yaml#376
- Fix quoted comments by
[@&#8203;WillAbides](https://togithub.com/WillAbides) in
[goccy/go-yaml#370
- Fix sequence with comment by
[@&#8203;goccy](https://togithub.com/goccy) in
[goccy/go-yaml#390
- bump actions/checkout v4 by
[@&#8203;shogo82148](https://togithub.com/shogo82148) in
[goccy/go-yaml#391
- add Go 1.21 to the build matrix by
[@&#8203;shogo82148](https://togithub.com/shogo82148) in
[goccy/go-yaml#392
- apply go fmt with Go 1.21 by
[@&#8203;shogo82148](https://togithub.com/shogo82148) in
[goccy/go-yaml#394
- bump actions/setup-go v4 by
[@&#8203;shogo82148](https://togithub.com/shogo82148) in
[goccy/go-yaml#393

#### New Contributors

- [@&#8203;WillAbides](https://togithub.com/WillAbides) made their first
contribution in
[goccy/go-yaml#370
- [@&#8203;shogo82148](https://togithub.com/shogo82148) made their first
contribution in
[goccy/go-yaml#391

**Full Changelog**:
goccy/go-yaml@v1.11.1...v1.11.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/anoriqq/qpm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants