Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle \r in a double-quoted string the same as \n #372

Merged
merged 2 commits into from
May 24, 2023

Conversation

k1LoW
Copy link
Sponsor Contributor

@k1LoW k1LoW commented May 7, 2023

Fix #371

If #371 is not the intended behavior, please consider merging this PR.

@codecov-commenter
Copy link

Codecov Report

Merging #372 (c775671) into master (1bbf205) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   75.61%   75.61%           
=======================================
  Files          13       13           
  Lines        4650     4650           
=======================================
  Hits         3516     3516           
  Misses        874      874           
  Partials      260      260           

Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !!! LGTM !

@goccy goccy merged commit 6a080f2 into goccy:master May 24, 2023
18 checks passed
@k1LoW k1LoW deleted the fix-decode-cr branch May 24, 2023 10:07
renovate bot added a commit to anoriqq/qpm that referenced this pull request Sep 14, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/goccy/go-yaml](https://togithub.com/goccy/go-yaml) |
require | patch | `v1.11.0` -> `v1.11.1` |

---

### Release Notes

<details>
<summary>goccy/go-yaml (github.com/goccy/go-yaml)</summary>

###
[`v1.11.1`](https://togithub.com/goccy/go-yaml/releases/tag/v1.11.1):
1.11.1

[Compare
Source](https://togithub.com/goccy/go-yaml/compare/v1.11.0...v1.11.1)

#### What's Changed

- Handle `\r` in a double-quoted string the same as `\n` by
[@&#8203;k1LoW](https://togithub.com/k1LoW) in
[goccy/go-yaml#372
- chore: replace loop with n.Values = append(n.Values, target.Values...)
by [@&#8203;testwill](https://togithub.com/testwill) in
[goccy/go-yaml#380
- fix: skip encoding an inline field if it is null by
[@&#8203;zoncoen](https://togithub.com/zoncoen) in
[goccy/go-yaml#386
- Fix comment parsing with null value by
[@&#8203;goccy](https://togithub.com/goccy) in
[goccy/go-yaml#388

#### New Contributors

- [@&#8203;testwill](https://togithub.com/testwill) made their first
contribution in
[goccy/go-yaml#380

**Full Changelog**:
goccy/go-yaml@v1.11.0...v1.11.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/anoriqq/qpm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling of Carriage Return (\r) in a double-quoted string differs from gopkg.in/yaml.*.
3 participants