example: add Go fuzz for PathList #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR shows a problem with input validation in go-yaml by adding a Go fuzz target.
If you are not familiar with Go 1.18 fuzzy tests, see https://tip.golang.org/doc/tutorial/fuzz.
The main problem is that the code does input validation with a deny list, while for robustness
it should do the opposite, use an explicit allow list. See for example
https://guides.codepath.org/websecurity/Prefer-whitelisting-over-blacklisting
This PR is not meant to be merged as-is; it is only a suggestion for how you could make
go-yaml more robust.