Skip to content

Commit

Permalink
fix custom marshaler (#333)
Browse files Browse the repository at this point in the history
  • Loading branch information
goccy committed Dec 19, 2022
1 parent dc3fed8 commit 45bdea2
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 2 deletions.
2 changes: 1 addition & 1 deletion encode.go
Expand Up @@ -642,7 +642,7 @@ func (e *Encoder) encodeStruct(ctx context.Context, value reflect.Value, column
if err != nil {
return nil, errors.Wrapf(err, "failed to encode value")
}
if _, ok := value.(*ast.MappingNode); ok {
if _, ok := value.(ast.MapNode); ok {
value.AddColumn(e.indent)
}
var key ast.MapKeyNode = e.encodeString(structField.RenderName, column)
Expand Down
42 changes: 42 additions & 0 deletions encode_test.go
Expand Up @@ -1473,3 +1473,45 @@ a:
t.Fatalf("failed to encode. expected %s but got %s", expected, got)
}
}

type customMapSliceOneItemMarshaler struct{}

func (m *customMapSliceOneItemMarshaler) MarshalYAML() ([]byte, error) {
var v yaml.MapSlice
v = append(v, yaml.MapItem{"a", "b"})
return yaml.Marshal(v)
}

type customMapSliceTwoItemMarshaler struct{}

func (m *customMapSliceTwoItemMarshaler) MarshalYAML() ([]byte, error) {
var v yaml.MapSlice
v = append(v, yaml.MapItem{"a", "b"})
v = append(v, yaml.MapItem{"b", "c"})
return yaml.Marshal(v)
}

func TestCustomMapSliceMarshaler(t *testing.T) {
type T struct {
A *customMapSliceOneItemMarshaler `yaml:"a"`
B *customMapSliceTwoItemMarshaler `yaml:"b"`
}
b, err := yaml.Marshal(&T{
A: &customMapSliceOneItemMarshaler{},
B: &customMapSliceTwoItemMarshaler{},
})
if err != nil {
t.Fatal(err)
}
expected := `
a:
a: b
b:
a: b
b: c
`
got := "\n" + string(b)
if expected != got {
t.Fatalf("failed to encode. expected %s but got %s", expected, got)
}
}
1 change: 0 additions & 1 deletion go.sum
Expand Up @@ -28,7 +28,6 @@ golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20200116001909-b77594299b42/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20200223170610-d5e6a3e2c0ae h1:/WDfKMnPU+m5M4xB+6x4kaepxRw6jWvR5iDRdvjHgy8=
golang.org/x/sys v0.0.0-20200223170610-d5e6a3e2c0ae/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20220406163625-3f8b81556e12 h1:QyVthZKMsyaQwBTJE04jdNN0Pp5Fn9Qga0mrgxyERQM=
golang.org/x/sys v0.0.0-20220406163625-3f8b81556e12/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
Expand Down

0 comments on commit 45bdea2

Please sign in to comment.