fix: add a fallback uint8 sliceDecoder to bytesDecoder #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @goccy |
|
@orisano Could you please update linter's version ? ( maybe this lint error caused by go1.18 and golangci-lint 1.36.0 ) |
|
Do I do that in this PR? |
|
It's okay in this PR :) |
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
- Coverage 79.86% 79.86% -0.01%
==========================================
Files 52 52
Lines 17509 17508 -1
==========================================
- Hits 13984 13982 -2
+ Misses 2958 2957 -1
- Partials 567 569 +2 |
|
Please add kind of linter with |
|
I did it! |
|
Thank you !! LGTM ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #360