Upgrade jackc/pgx to v5 #819
Conversation
Version 5 of pgx finally resolves some long-awaited issues when PostgreSQL shuts down. The upgrade is a drop-in replacement with the only change being the pgconn import path. See ory/hydra#3432 Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
In order to support improve PostgreSQL connectivity, Go 1.18 is required. Go 1.17's support ended 7 months ago. Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
| @@ -20,6 +20,9 @@ func (f Float) Interface() interface{} { | |||
| func (f *Float) Scan(src interface{}) error { | |||
| var str string | |||
| switch t := src.(type) { | |||
| case nil: | |||
There was a problem hiding this comment.
Could it be changed to the general nil checking like the String case for readability? The other types too, including Map.
There was a problem hiding this comment.
Actually, that change broke the whole thing haha. We must distinguish between a nil interface and a non-nil interface backed by nil.
I've changed the String case to match the other implementations.
There was a problem hiding this comment.
maybe a different confusion here. if the type switch's case nil works like your PR, that means the src has no specific type and is actually nil so src == nil should be true. If the src is a "non-nil interface with a nil value", the type of src can't be nil and the case nil will not work. What is the actual src in here? something like *[]string(nil)?
I hope we have enough description on the PR or linked issue so we can have a solid reference for the chance in the code history.
sio4
added
s: accepted
|
pgx/v5 is a pretty big change from v4. I've changed this PR back to draft while waiting for some insights here: jackc/pgx#1566 |
What is being done in this PR?
Closes #818
Supersedes #814
What are the main choices made to get to this solution?
jackc/pgx/v5 has slightly different handling of SQL NULLs than v4. Otherwise, this was a drop-in replacement.
List the manual test cases you've covered before sending this PR:
Ran tests against postgres locally.