Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed mysqldump option --column-statistics to make it compatible with 5.7 #776

Merged
merged 2 commits into from Sep 24, 2022
Merged

removed mysqldump option --column-statistics to make it compatible with 5.7 #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ac7395
removed mysqldump option --column-statistics to make it compatible
sio4 Sep 22, 2022
a749e2a
Merge branch 'main' into fix-mysqldump
sio4 Sep 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Expand Up @@ -32,6 +32,12 @@ jobs:
with:
go-version: ${{ matrix.go-version }}

- name: Setup MySQL environment
run: |
mysqldump --version
echo $HOME
echo -e "[mysqldump]\ncolumn-statistics=0" > $HOME/.my.cnf

- name: Build and run soda
env:
SODA_DIALECT: "mysql"
Expand Down
5 changes: 2 additions & 3 deletions dialect_mysql.go
View file
Open in desktop
Expand Up @@ -192,10 +192,9 @@ func (m *mysql) FizzTranslator() fizz.Translator {

func (m *mysql) DumpSchema(w io.Writer) error {
deets := m.Details()
// Github CI is currently using mysql:5.7 but the mysqldump version doesn't seem to match
cmd := exec.Command("mysqldump", "--column-statistics=0", "-d", "-h", deets.Host, "-P", deets.Port, "-u", deets.User, fmt.Sprintf("--password=%s", deets.Password), deets.Database)
cmd := exec.Command("mysqldump", "-d", "-h", deets.Host, "-P", deets.Port, "-u", deets.User, fmt.Sprintf("--password=%s", deets.Password), deets.Database)
if deets.Port == "socket" {
cmd = exec.Command("mysqldump", "--column-statistics=0", "-d", "-S", deets.Host, "-u", deets.User, fmt.Sprintf("--password=%s", deets.Password), deets.Database)
cmd = exec.Command("mysqldump", "-d", "-S", deets.Host, "-u", deets.User, fmt.Sprintf("--password=%s", deets.Password), deets.Database)
}
return genericDumpSchema(deets, cmd, w)
}
Expand Down