Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve several panics, incorrect reflection uses, and eager bugs #680

Merged
merged 13 commits into from Dec 10, 2021
Merged

Resolve several panics, incorrect reflection uses, and eager bugs #680

merged 13 commits into from Dec 10, 2021

Commits on Dec 8, 2021

  1. Resolve EagerPreload panic caused for pointer references 

    Resolves a panic where `EagerPreload` tried to set `reflect.Struct` for a `reflect.Pointer` on 1.. associations.

Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 8, 2021
    Copy the full SHA
    7fd60cc View commit details
    Browse the repository at this point in the history

  2. Resolve EagerPreload panic caused by NullUUID 

    Resolves a panic where `EagerPreload` was trying to set UUID into NullUUID.

Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 8, 2021
    Copy the full SHA
    e3824f8 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Support pointers in n+1 Eager loading 

    Resolves an issue where n+1 eager associations would error with a double pointer in `associations.ForStruct`.

Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 9, 2021
    Copy the full SHA
    ff8d5e4 View commit details
    Browse the repository at this point in the history

  2. Improve error message of associations.ForStruct 

    Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 9, 2021
    Copy the full SHA
    c47e802 View commit details
    Browse the repository at this point in the history

  3. Add test cases for IsZeroOfUnderlyingType 

    Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 9, 2021
    Copy the full SHA
    950114c View commit details
    Browse the repository at this point in the history

  4. Resolve an obscure bug where empty structs got loaded for NULL foreig… 

    …n keys

Closes #139

Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 9, 2021
    Copy the full SHA
    f877758 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Resolve association regression in finders.go 

    Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 10, 2021
    Copy the full SHA
    faa2a00 View commit details
    Browse the repository at this point in the history

  2. Use dedicated migrations for preloading regression test 

    Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 10, 2021
    Copy the full SHA
    6c83744 View commit details
    Browse the repository at this point in the history

  3. Fix code regression 

    Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 10, 2021
    Copy the full SHA
    9b68e04 View commit details
    Browse the repository at this point in the history

  4. Fix test code regressions 

    Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 10, 2021
    Copy the full SHA
    07963a0 View commit details
    Browse the repository at this point in the history

  5. Fix sql migration order 

    Signed-off-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
    @aeneasr
    aeneasr committed Dec 10, 2021
    Copy the full SHA
    b8b0043 View commit details
    Browse the repository at this point in the history

  6. Resolve order issue in test

    @aeneasr
    aeneasr committed Dec 10, 2021
    Copy the full SHA
    e4f3f7e View commit details
    Browse the repository at this point in the history

  7. Ignore order when testing for nil values in test

    @aeneasr
    aeneasr committed Dec 10, 2021
    Copy the full SHA
    31bd5b5 View commit details
    Browse the repository at this point in the history