Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated module dependencies #666

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/tests.yml
Expand Up @@ -17,12 +17,12 @@ jobs:

steps:
- name: Set up Go
uses: actions/setup-go@v1
uses: actions/setup-go@v2
with:
go-version: 1.15
go-version: 1.16
id: go
- name: Checkout Code
uses: actions/checkout@v1
uses: actions/checkout@v2
with:
fetch-depth: 1
- name: Get dependencies
Expand Down Expand Up @@ -62,12 +62,12 @@ jobs:

steps:
- name: Set up Go
uses: actions/setup-go@v1
uses: actions/setup-go@v2
with:
go-version: 1.15
go-version: 1.16
id: go
- name: Checkout Code
uses: actions/checkout@v1
uses: actions/checkout@v2
with:
fetch-depth: 1
- name: Get dependencies
Expand Down Expand Up @@ -95,12 +95,12 @@ jobs:

steps:
- name: Set up Go
uses: actions/setup-go@v1
uses: actions/setup-go@v2
with:
go-version: 1.15
go-version: 1.16
id: go
- name: Checkout Code
uses: actions/checkout@v1
uses: actions/checkout@v2
with:
fetch-depth: 1
- name: Get dependencies
Expand Down Expand Up @@ -137,12 +137,12 @@ jobs:

steps:
- name: Set up Go
uses: actions/setup-go@v1
uses: actions/setup-go@v2
with:
go-version: 1.15
go-version: 1.16
id: go
- name: Checkout Code
uses: actions/checkout@v1
uses: actions/checkout@v2
with:
fetch-depth: 1
- name: Get dependencies
Expand Down Expand Up @@ -179,12 +179,12 @@ jobs:

steps:
- name: Set up Go
uses: actions/setup-go@v1
uses: actions/setup-go@v2
with:
go-version: 1.15
go-version: 1.16
id: go
- name: Checkout Code
uses: actions/checkout@v1
uses: actions/checkout@v2
with:
fetch-depth: 1
- name: Get dependencies
Expand Down
45 changes: 21 additions & 24 deletions go.mod
@@ -1,36 +1,33 @@
module github.com/gobuffalo/pop/v5

go 1.15
go 1.16

replace github.com/mattn/go-sqlite3 => github.com/mattn/go-sqlite3 v1.14.7
replace github.com/mattn/go-sqlite3 => github.com/mattn/go-sqlite3 v1.14.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paganotoni This replace statement causes quite a bit of trouble and should be removed. This requires a temporary downgrade to fizz v1.10.0.

fizz can then be updated to use the newer version of pop without the replace statement, fixing the dependency graph of fizz.

Lastly this the new fizz version can be used here without the replace statement

I mention this issue in my PR: #667

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fasmat,

I didn't know you are preparing PR for pop when I requested this PR. Please ignore this PR and please go ahead with your #667! I will close this PR for now!


require (
github.com/fatih/color v1.9.0
github.com/go-kit/kit v0.10.0 // indirect
github.com/go-sql-driver/mysql v1.5.0
github.com/gobuffalo/attrs v0.1.0
github.com/gobuffalo/envy v1.8.1
github.com/gobuffalo/fizz v1.10.0
github.com/gobuffalo/flect v0.2.1
github.com/gobuffalo/genny/v2 v2.0.5
github.com/gobuffalo/helpers v0.6.1 // indirect
github.com/gobuffalo/logger v1.0.3
github.com/gobuffalo/nulls v0.2.0
github.com/gobuffalo/packd v1.0.0
github.com/gobuffalo/packr/v2 v2.8.0
github.com/gobuffalo/plush/v4 v4.0.0
github.com/gobuffalo/validate/v3 v3.1.0
github.com/gofrs/uuid v4.0.0+incompatible
github.com/fatih/color v1.13.0
github.com/go-sql-driver/mysql v1.6.0
github.com/gobuffalo/attrs v1.0.1
github.com/gobuffalo/envy v1.10.1
github.com/gobuffalo/fizz v1.13.1
github.com/gobuffalo/flect v0.2.4
github.com/gobuffalo/genny/v2 v2.0.8
github.com/gobuffalo/logger v1.0.6
github.com/gobuffalo/nulls v0.4.1
github.com/gobuffalo/packd v1.0.1
github.com/gobuffalo/packr/v2 v2.8.2
github.com/gobuffalo/plush/v4 v4.1.9
github.com/gobuffalo/validate/v3 v3.3.1
github.com/gofrs/uuid v4.1.0+incompatible
github.com/jackc/pgconn v1.10.0
github.com/jackc/pgx/v4 v4.13.0
github.com/jmoiron/sqlx v1.3.3
github.com/karrick/godirwalk v1.16.1 // indirect
github.com/lib/pq v1.10.2
github.com/jmoiron/sqlx v1.3.4
github.com/lib/pq v1.10.4
github.com/luna-duclos/instrumentedsql v1.1.3
github.com/mattn/go-sqlite3 v2.0.3+incompatible
github.com/pkg/errors v0.9.1
github.com/spf13/cobra v0.0.6
github.com/spf13/cobra v1.2.1
github.com/stretchr/testify v1.7.0
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
gopkg.in/yaml.v2 v2.2.8
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
gopkg.in/yaml.v2 v2.4.0
)