Use PaginatorPageKey and PaginatorPerPageKey variables (#615)

* update pagination_test
gobuffalo · Feb 6, 2021 · e314840 · e314840
1 parent ad18e4d
commit e314840
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pagination_test.go b/pagination_test.go
@@ -31,12 +31,12 @@ func Test_NewPaginatorFromParams(t *testing.T) {
 	a.Equal(p.Page, 1)
 	a.Equal(p.PerPage, 20)
 
-	params.Set("page", "2")
+	params.Set(PaginatorPageKey, "2")
 	p = NewPaginatorFromParams(params)
 	a.Equal(p.Page, 2)
 	a.Equal(p.PerPage, 20)
 
-	params.Set("per_page", "30")
+	params.Set(PaginatorPerPageKey, "30")
 	p = NewPaginatorFromParams(params)
 	a.Equal(p.Page, 2)
 	a.Equal(p.PerPage, 30)

diff --git a/paginator.go b/paginator.go
@@ -75,9 +75,9 @@ type PaginationParams interface {
 // `PaginatorPerPageKey`. Defaults are `1` for the page and
 // PaginatorPerPageDefault for the per page value.
 func NewPaginatorFromParams(params PaginationParams) *Paginator {
-	page := defaults.String(params.Get("page"), "1")
+	page := defaults.String(params.Get(PaginatorPageKey), "1")
 
-	perPage := defaults.String(params.Get("per_page"), strconv.Itoa(PaginatorPerPageDefault))
+	perPage := defaults.String(params.Get(PaginatorPerPageKey), strconv.Itoa(PaginatorPerPageDefault))
 
 	p, err := strconv.Atoi(page)
 	if err != nil {