Upgrade i18mw package to use io/fs over packr/packd #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
paganotoni
approved these changes
Nov 23, 2021
|
@paganotoni please reopen this PR. gobuffalo/buffalo#2166 has to be merged first and I have to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the i18mw package to use io/fs over packr/packd
I updated the github workflows to use more recent versions of golang and added a dependabot config for go and github actions.
I don't know why the
github.com/nicksnyder/go-i18nwas copied into an internal folder instead of just using the package from the original author. The version used seems to be 1.10.0 from Nov 2017. I didn't try to upgrade to a more recent version since v2.x.x seem to have a very different API and I'm not sure about the effort to upgrade.This should be merged after these PRs have been merged and the dependencies were updated accordingly: