Respect auto_index keys in crdb #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch reverts a behavior introduced earlier and adds a test to prevent future regressions. With this patch, it is possible to use `change_column` on columns with foreign key references but without explicitly defined indices. Without this patch, those changes fail because CRDB needs an index on the referencing column when creating foreign key checks. Closes #98
|
@stanislas-m could you give this some 👀 ? :) |
|
Sure, I'll take a look this weekend. Sorry for the delay. |
stanislas-m
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reverts a behavior introduced earlier and adds a test to prevent future regressions. With this patch, it is possible to use
change_columnon columns with foreign key references but without explicitly defined indices. Without this patch, those changes fail because CRDB needs an index on the referencing column when creating foreign key checks.Closes #98