This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
added assert middleware to assert handler's behavior. (fix #2339) #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paganotoni
suggested changes
Oct 26, 2022
There was a problem hiding this comment.
I like it. @sio4 Is there a chance we could add some tests to leave this behavior specified and guaranteed after v1.1.0 ?
Sure, I agree. Will do that soon. (Maybe by this week) |
sio4
force-pushed
the
adding-assert-middleware
branch
from
821474b
to
0439594
Compare
paganotoni
approved these changes
Oct 27, 2022
| @@ -242,3 +243,67 @@ func Test_Middleware_Remove(t *testing.T) { | |||
| _ = w.HTML("/no_log_autos/1").Get() | |||
| r.Len(log, 0) | |||
| } | |||
|
|
|||
| func Test_AssertMiddleware_NilStatus200(t *testing.T) { | |||
There was a problem hiding this comment.
This is great! Thanks @sio4 !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the net/http#ResponseWriter,
Write()will set the response status as "200 OK" if a handler exited without callingWriteHeader()but returnsnil. However, the Buffalo's behavior is slightly different. The Buffalo's actual responding behavior is basically the same since it uses the same, but the buffalo's middlewares (especiallypoptxfrombuffalo-pop) could treat them as a failed action when no response status is found. This inconsistency made some issues and this PR will fix the issue.See more details in #2339 and other linked issues.
fixes #2339
fixes gobuffalo/buffalo-pop#25
fixes gobuffalo/buffalo-pop#19
related issues/PRs: #2300, #2334, #2335,