Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integration/netbox: fix group custom pipeline example #9738

Merged
merged 1 commit into from
May 21, 2024

Conversation

thystips
Copy link
Contributor

Details

Fix example for Netbox integration for version 4.0.0 and above.
Group in Netbox is now a Netbox custom model and not the django's one.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@thystips thystips requested a review from a team as a code owner May 15, 2024 12:19
Copy link

netlify bot commented May 15, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit f8aec65
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/664c8002aa038e0009e764c0
😎 Deploy Preview https://deploy-preview-9738--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit f8aec65
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/664c8002127779000883fc15

@rissson rissson requested a review from tanberry May 21, 2024 10:22
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (6ffef87) to head (f8aec65).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9738      +/-   ##
==========================================
- Coverage   92.65%   92.63%   -0.02%     
==========================================
  Files         708      708              
  Lines       34619    34619              
==========================================
- Hits        32077    32071       -6     
- Misses       2542     2548       +6     
Flag Coverage Δ
e2e 49.57% <ø> (-0.02%) ⬇️
integration 25.34% <ø> (ø)
unit 90.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ThysTips <contact@antoinethys.com>
@BeryJu BeryJu merged commit 6e31e5b into goauthentik:main May 21, 2024
62 of 67 checks passed
kensternberg-authentik added a commit that referenced this pull request May 24, 2024
* main: (36 commits)
  ci: use container registry for container build cache (#9809)
  core: bump lxml from 5.2.1 to 5.2.2 (#9717)
  web: bump mermaid from 10.9.0 to 10.9.1 in /web (#9734)
  core: bump scim2-filter-parser from 0.5.0 to 0.5.1 (#9730)
  web: bump core-js from 3.37.0 to 3.37.1 in /web (#9733)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9729)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9802)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9803)
  core: bump sentry-sdk from 2.2.0 to 2.2.1 (#9807)
  web: bump the storybook group in /web with 7 updates (#9804)
  web: bump glob from 10.3.15 to 10.3.16 in /web (#9805)
  root: docker-compose: remove version top level element (#9631)
  core, web: update translations (#9790)
  web: bump API Client version (#9801)
  web/admin: rework initial wizard pages and add grid layout (#9668)
  website/integrations: discord: fix typo (#9800)
  website/integration/netbox: fix group custom pipeline example (#9738)
  root: add primary-replica db router (#9479)
  website/integrations: add three more policy-expressions to discord-docs (#5760)
  website/integrations: netbox: add missing scope configuration (#9491)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants