gh-75 fixing babel cache issue

[goatandsheep]

Link to issue

fixes #75

Description of changes being made

• refactor to work with new babel version

[goatandsheep]

This will duplicate functionality so closes #290

[codecov]

Codecov Report

Merging #288 (5bd695a) into main (e68997c) will increase coverage by 0.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   98.21%   98.97%   +0.76%     
==========================================
  Files           1        1              
  Lines          56       98      +42     
==========================================
+ Hits           55       97      +42     
  Misses          1        1              

Impacted Files	Coverage Δ
index.js	98.97% <100.00%> (+0.76%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68997c...5bd695a. Read the comment docs.

[nicolo-ribaudo]

You might want to wrap this in cache.using, so that if the env changes without restarting Node.js the plugin is reinstantiated.

[goatandsheep]

thank you! I moved things around. I still don't know if it will reload properly in hot reload, but I don't think the environment mode can change without a js reload so I left that out. Hopefully it works in other tests when we release it in @next!

[goatandsheep]

I am the second maintainer to this project so I'm not even sure about how all the babel features work

[nicolo-ribaudo]

The function passed to api.cache.using should return a value that, when it changes, causes the plugin to be re-instantiated. Since this one always returns undefined, the plugin will never be re-instantiated and it will always use the initial .env file.

I suggest doing something like this:

function mtime(filePath) {
  try {
    return fs.statSync(filePath).mtimeMs
  } catch {
    return null
  }
}

api.cache.using(() => mtime(options.path))
api.cache.using(() => mtime(localFilePath))
api.cache.using(() => mtime(modeFilePath))
api.cache.using(() => mtime(modeLocalFilePath))

let env

if (options.safe) {
  const parsed = parseDotenvFile(options.path, options.verbose)
  const localParsed = parseDotenvFile(localFilePath, options.verbose)
  const modeParsed = parseDotenvFile(modeFilePath, options.verbose)
  const modeLocalParsed = parseDotenvFile(modeLocalFilePath, options.verbose)
  
  env = Object.assign(Object.assign(Object.assign(parsed, modeParsed), localParsed), modeLocalParsed)
} else {
  dotenv.config({
    path: modeLocalFilePath,
    silent: true,
  })
  dotenv.config({
    path: modeFilePath,
    silent: true,
  })
  dotenv.config({
    path: localFilePath,
    silent: true,
  })
  dotenv.config({
    path: options.path,
  })
      
  env = process.env
}

[goatandsheep]

so when it is re-initialized, pre() is rerun?

[goatandsheep]

so I found that this did not work in tests unfortunately. do I also need to use addExternalDependency?

[goatandsheep]

Codecoverage issue

targetObject[keys[i]] = sourceObject[keys[i]]
  | 26