zmq4: resend subscriptions in socket.addConn

[thielepaul]

Fixes #116

[codecov]

Codecov Report

Merging #128 (e092dc6) into main (16d169c) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   67.53%   67.41%   -0.12%     
==========================================
  Files          29       29              
  Lines        1814     1817       +3     
==========================================
  Hits         1225     1225              
- Misses        489      491       +2     
- Partials      100      101       +1     

Impacted Files	Coverage Δ
socket.go	83.23% <100.00%> (+0.19%)	⬆️
sub.go	76.92% <100.00%> (+0.45%)	⬆️
conn.go	55.17% <0.00%> (-1.15%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d169c...e092dc6. Read the comment docs.

[sbinet]

looking good.
see my little nit-pick oriented comments below.

(thanks for the PR)

[thielepaul]

@sbinet I don't understand how the coverage in conn.go is reduced by my changes, do you understand what is going on there?

[sbinet]

code coverage (with codecov) can be a bit flaky, in my experience.

[sbinet]

LGTM.

could you send another PR against go-zeromq/license, adding yourself to the AUTHORS and/or CONTRIBUTORS files?

thanks again for the PR.

[sbinet]

needs go-zeromq/license#12

[sbinet]

thanks again (and welcome!)