Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hello example #121

Merged
merged 6 commits into from Jun 2, 2022
Merged

add hello example #121

merged 6 commits into from Jun 2, 2022

Conversation

ijt
Copy link
Contributor

@ijt ijt commented Jun 1, 2022

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #121 (a37190e) into master (b7c2c56) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   67.40%   67.19%   -0.21%     
==========================================
  Files          29       29              
  Lines        1813     1814       +1     
==========================================
- Hits         1222     1219       -3     
- Misses        490      493       +3     
- Partials      101      102       +1     
Impacted Files Coverage Δ
internal/inproc/inproc.go 70.88% <0.00%> (-1.27%) ⬇️
conn.go 54.02% <0.00%> (-1.15%) ⬇️
msg.go 68.29% <0.00%> (ø)
security.go 44.44% <0.00%> (ø)
socket_types.go 92.15% <0.00%> (ø)
cxx_zmq4_compat.go 47.05% <0.00%> (ø)
security/null/null.go 47.36% <0.00%> (ø)
security/plain/plain.go 43.93% <0.00%> (ø)
protocol.go 77.57% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c2c56...a37190e. Read the comment docs.

Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the small nit-pick.

could you send another PR against go-zeromq/license adding yourself to the AUTHOR and/or CONTRIBUTORS files?

thanks.

example/helloclient.go Outdated Show resolved Hide resolved
example/helloserver.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(put please send another PR against go-zeromq/license adding yourself to the AUTHORS and/or CONTRIBUTORS files. then I'll merge this PR in)

@ijt
Copy link
Contributor Author

ijt commented Jun 1, 2022

Got it. I don't see an AUTHORS file or a CONTRIBUTORS file. Did you want me to add one?

@sbinet
Copy link
Contributor

sbinet commented Jun 1, 2022

these files are in the license repo:

https://github.com/go-zeromq/license

@ijt
Copy link
Contributor Author

ijt commented Jun 2, 2022

these files are in the license repo:

https://github.com/go-zeromq/license

Got that. Pull requests created.

@sbinet
Copy link
Contributor

sbinet commented Jun 2, 2022

needs go-zeromq/license#10 and go-zeromq/license#11

@sbinet
Copy link
Contributor

sbinet commented Jun 2, 2022

thanks a lot and welcome to go-zeromq :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants