Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten restrictions on float decoding #171

Merged
merged 2 commits into from Jan 25, 2017
Merged

Tighten restrictions on float decoding #171

merged 2 commits into from Jan 25, 2017

Commits on Apr 26, 2016

  1. Add test for YAML float regex

    Alex Harford committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    8c66b44 View commit details
    Browse the repository at this point in the history

  2. Tighten restrictions on float checks 

    ParseFloat() accepts strings that contain digits with a single 'e'
character somewhere in the middle as valid floats. The YAML spec does
not accept these.

This causes problems especially when dealing with short commit hashes,
e.g. `123456e1`

This regex isn't exactly the same as the YAML spec. It continues to
allow decimals like `0.1` to be parsed as floats.
    Alex Harford committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    fcc3bda View commit details
    Browse the repository at this point in the history