Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simple key handling #1031

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Fix simple key handling #1031

wants to merge 1 commit into from

Conversation

DMaxter
Copy link

@DMaxter DMaxter commented Apr 14, 2024

Currently if a key is more than 128 characters, it is handled as a complex mapping key, however this goes against the YAML spec as pointed out in #849 (comment) . Can be read here: https://yaml.org/spec/1.2.2/#flow-mappings

This causes issues when handling OpenAPI specifications with paths longer than 128 characters, making them invalid.

This PR aims to fix this issue, which is also affecting yq as can be seen here mikefarah/yq#1192

Fixes #849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key size in dicts seems to be limited to 128 characters
1 participant