Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add integration test for exec() #336

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented May 9, 2022

Part of go-vela/community#585

This adds some integration tests for the exec() function. It only adds them for the docker runtime, as it is currently hanging for kubernetes. I will fix the kubernetes runtime in follow-up PRs.

I also had to add a mock API server for the worker. I based it on the server's mock.

@cognifloyd cognifloyd requested a review from a team as a code owner May 9, 2022 22:09
@cognifloyd cognifloyd added the enhancement Indicates an improvement to a feature label May 9, 2022
@cognifloyd cognifloyd self-assigned this May 9, 2022
@cognifloyd cognifloyd requested review from jbrockopp and kneal May 9, 2022 22:09
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #336 (ee0c132) into master (6c8171c) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   81.17%   81.04%   -0.14%     
==========================================
  Files          68       70       +2     
  Lines        5274     5417     +143     
==========================================
+ Hits         4281     4390     +109     
- Misses        849      873      +24     
- Partials      144      154      +10     
Impacted Files Coverage Δ
cmd/vela-worker/exec.go 74.16% <100.00%> (ø)
runtime/setup.go 100.00% <100.00%> (ø)
cmd/vela-worker/client.go 76.92% <0.00%> (ø)

mock/worker/server.go Outdated Show resolved Hide resolved
@cognifloyd cognifloyd force-pushed the exec-tests branch 3 times, most recently from 41813c5 to cf7bfed Compare May 10, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

1 participant