Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jwt): set issued_at to nil prior to validating claims #813

Merged
merged 2 commits into from Apr 11, 2023

Conversation

ecrupper
Copy link
Contributor

Due to some clock skew, we began seeing token used before issued errors. We noticed this issue in the JWT library, which appears to be resolved in their upcoming v5 release. In that release, they will be making issued_at unchecked by default, due to its optional nature. I elaborated on this in the code comments as well.

@ecrupper ecrupper self-assigned this Apr 11, 2023
@ecrupper ecrupper requested a review from a team as a code owner April 11, 2023 17:22
@ecrupper ecrupper changed the base branch from main to v0.18.2 April 11, 2023 17:24
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #813 (9cb91a5) into v0.18.2 (a3ab6f0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 9cb91a5 differs from pull request most recent head bfe9428. Consider uploading reports for the commit bfe9428 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.18.2     #813      +/-   ##
===========================================
+ Coverage    54.87%   54.88%   +0.01%     
===========================================
  Files          244      244              
  Lines        16506    16510       +4     
===========================================
+ Hits          9058     9062       +4     
  Misses        7048     7048              
  Partials       400      400              
Impacted Files Coverage Δ
internal/token/parse.go 91.89% <100.00%> (+0.98%) ⬆️

@ecrupper ecrupper merged commit ad79b9a into v0.18.2 Apr 11, 2023
9 checks passed
@ecrupper ecrupper deleted the patch/issued_at branch April 11, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants