Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat dial error as driver.ErrBadConn #867

Merged
merged 5 commits into from Oct 31, 2018
Merged

Treat dial error as driver.ErrBadConn #867

merged 5 commits into from Oct 31, 2018

Commits on Oct 12, 2018

  1. return driver.ErrBadConn if Dial() fails

    because this error is retried in the driver and means the connection never succeeded
    
    ```
    // ErrBadConn should be returned by a driver to signal to the sql
    // package that a driver.Conn is in a bad state (such as the server
    // having earlier closed the connection) and the sql package should
    // retry on a new connection.
    //
    // To prevent duplicate operations, ErrBadConn should NOT be returned
    // if there's a possibility that the database server might have
    // performed the operation. Even if the server sends back an error,
    // you shouldn't return ErrBadConn.
    ```
    Tom Jenkinson committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    d115a62 View commit details
    Browse the repository at this point in the history
  2. log actual error when dial() fails

    Tom Jenkinson committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    f0fc329 View commit details
    Browse the repository at this point in the history
  3. add name to AUTHORS

    Tom Jenkinson committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    5d02613 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2018

  1. Configuration menu
    Copy the full SHA
    bc42363 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2018

  1. only return driver.ErrBadConn on temporary error

    Tom Jenkinson committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    eebeab7 View commit details
    Browse the repository at this point in the history