Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog for releasing v1.8.1 #1576

Merged
merged 1 commit into from Mar 26, 2024

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Mar 26, 2024

Description

#1559 and #1567 are fixed.
Let's release a new version v1.8.1.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

  • Bug Fixes

    • Addressed race condition issues for enhanced stability.
  • New Features

    • Improved database compatibility with charset and collation adjustments.
    • Enhanced security and flexibility through the introduction of new configuration options.
  • Major Changes

    • Dropped support for older versions of Go (1.13-1.17) to leverage newer language features.
    • Improved number parsing for efficiency and accuracy.
    • Added configurable logging per connection for better diagnostics.
  • Enhancements

    • Fixed issues with ColumnType.DatabaseTypeName to improve data handling.
    • Introduced connection attributes for more detailed connection information.

Copy link

coderabbitai bot commented Mar 26, 2024

Walkthrough

This update introduces several significant enhancements and bug fixes to improve compatibility, performance, and usability. Key highlights include addressing race condition issues, dropping support for older Go versions, and implementing new options for better configuration and compatibility with MySQL. The changes aim to enhance the overall reliability and efficiency of the application, making it more robust and user-friendly.

Changes

Files Change Summary
.../internal/... Bugfixes addressing race condition issues
.../mysql/... Major updates for charset compatibility, DSN path escaping, dropping older Go support, number parsing, and new option patterns
.../config/... Enhancements like configurable logger, fixed ColumnType.DatabaseTypeName, connection attributes

Related issues

  • context deadline exceeded #1528: The enhancements and bugfixes in this PR could potentially address the "context deadline exceeded" error by improving connection handling and compatibility, which aligns with the objectives to maintain connection settings and behaviors.
  • Likely race that can prevent to recycle closed connections #1542: The major changes in version 1.8.0, particularly around connection handling and error reporting, may offer insights or solutions to the "invalid connection" error, aligning with the issue's objective to investigate connection recycling and error handling improvements.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@shogo82148
Copy link
Contributor Author

@coderabbitai review

@coveralls
Copy link

Coverage Status

coverage: 82.526%. remained the same
when pulling 23c8776 on shogo82148:prepare-for-v1.8.1
into 7eeaba6 on go-sql-driver:1.8.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7eeaba6 and 23c8776.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional comments: 2
CHANGELOG.md (2)
  • 7-42: The major changes listed for version 1.8.0 include several enhancements and new features, such as using SET NAMES charset COLLATE collation, path escaping of dbname in DSN, dropping support for older Go versions, and introducing new options using the Functional Option Pattern. Verify that these changes have been implemented as described and that the documentation accurately reflects the functionality and implications of these changes.
Verification successful

The major changes listed for version 1.8.0, including the use of SET NAMES charset COLLATE collation, path escaping of dbname in DSN, dropping support for older Go versions, and the introduction of new options using the Functional Option Pattern, are accurately documented in the CHANGELOG.md as verified by the shell script output. The documentation reflects the functionality and implications of these changes as described.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify the implementation of major changes for version 1.8.0.
# Check for commits or pull requests implementing the mentioned features.
rg --type md 'SET NAMES charset COLLATE collation' CHANGELOG.md
rg --type md 'PathEscape dbname in DSN' CHANGELOG.md
rg --type md 'Drop Go 1.13-17 support' CHANGELOG.md
rg --type md 'Functional Option Pattern' CHANGELOG.md

Length of output: 853

* 30-42: The "Other changes" section for version 1.8.0 lists various enhancements and fixes. It's important to ensure that each listed change is accurately described and that the links to pull requests or issues are correct and lead to the relevant discussions or implementations.
Verification successful

To continue verifying the accuracy and relevance of the links in the "Other changes" section, the next step involves checking the remaining pull requests. Here's the script to fetch and analyze the titles and descriptions of the next set of pull requests:


The verification process has confirmed that all links in the "Other changes" section of the CHANGELOG.md for version 1.8.0 are accurate and lead to the relevant discussions or implementations as described. Each listed change is accurately described, and the links to pull requests are correct.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify the accuracy and relevance of the links in the "Other changes" section.
curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1422 | jq '.title, .body'
curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1408 | jq '.title, .body'
curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1428 | jq '.title, .body'
# Continue for each link in the section.

Length of output: 2180



Script:

#!/bin/bash
# Continue verifying the accuracy and relevance of the links in the "Other changes" section.
curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1389 | jq '.title, .body'
curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1424 | jq '.title, .body'
curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1309 | jq '.title, .body'
curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1499 | jq '.title, .body'
curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1506 | jq '.title, .body'
curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1470 | jq '.title, .body'
curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1518 | jq '.title, .body'

Length of output: 9017

CHANGELOG.md Show resolved Hide resolved
@shogo82148 shogo82148 requested a review from a team March 26, 2024 14:28
@shogo82148
Copy link
Contributor Author

Thanks for reviewing

@shogo82148 shogo82148 merged commit 4395c45 into go-sql-driver:1.8 Mar 26, 2024
34 checks passed
@shogo82148 shogo82148 deleted the prepare-for-v1.8.1 branch March 26, 2024 14:34
shogo82148 added a commit to shogo82148/mysql that referenced this pull request Mar 26, 2024
### Description

go-sql-driver#1559 and
go-sql-driver#1567 are fixed.
Let's release a new version v1.8.1.

### Checklist
- [x] Code compiles correctly
- [x] Created tests which fail without the change (if possible)
- [x] All tests passing
- [x] Extended the README / documentation, if necessary
- [x] Added myself / the copyright holder to the AUTHORS file


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
	- Addressed race condition issues for enhanced stability.

- **New Features**
- Improved database compatibility with charset and collation
adjustments.
- Enhanced security and flexibility through the introduction of new
configuration options.

- **Major Changes**
- Dropped support for older versions of Go (1.13-1.17) to leverage newer
language features.
	- Improved number parsing for efficiency and accuracy.
	- Added configurable logging per connection for better diagnostics.

- **Enhancements**
- Fixed issues with ColumnType.DatabaseTypeName to improve data
handling.
- Introduced connection attributes for more detailed connection
information.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
shogo82148 added a commit that referenced this pull request Apr 30, 2024
cherry pick of
shogo82148@476df92

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
	- Addressed race conditions when the context is canceled.
- **New Features**
	- Enhanced database connection with charset and collation settings.
	- Improved path escaping in database names.
	- Dropped support for Go versions 1.13-17.
	- Implemented parsing numbers over text protocol.
	- Introduced new configuration options for advanced usage.
- **Enhancements**
	- Made logger configurable per connection.
- Fixed handling of `mediumint unsigned` in
`ColumnType.DatabaseTypeName`.
	- Added connection attributes for more detailed connection information.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
methane pushed a commit to methane/mysql that referenced this pull request Apr 30, 2024
…iver#1577)

cherry pick of
shogo82148@476df92

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
	- Addressed race conditions when the context is canceled.
- **New Features**
	- Enhanced database connection with charset and collation settings.
	- Improved path escaping in database names.
	- Dropped support for Go versions 1.13-17.
	- Implemented parsing numbers over text protocol.
	- Introduced new configuration options for advanced usage.
- **Enhancements**
	- Made logger configurable per connection.
- Fixed handling of `mediumint unsigned` in
`ColumnType.DatabaseTypeName`.
	- Added connection attributes for more detailed connection information.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants