Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proof of concepts: Introduce reader and write groutine #1491

Closed
wants to merge 107 commits into from
Closed

proof of concepts: Introduce reader and write groutine #1491

wants to merge 107 commits into from

Conversation

shogo82148
Copy link
Contributor

Description

addresses #1451 (comment)

As one more point of reference, the Go HTTP client fires off a goroutine running a readLoop when a connection is first established.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@shogo82148
introduce writer goroutine
e4761dd
@shogo82148
skip failing tests
5ec520f
@shogo82148
introduce reader loop
22dd1e4
@shogo82148
Merge branch 'master' into introduce-reader-and-write-groutine-3
df63ad7
@shogo82148
skip failing test: TestConnectionAttributes
a2f43e6
@shogo82148
fix compile error
8888cbe
@shogo82148
skip failing test
62a33a1
@shogo82148
suppress warnings
9d248ae
@shogo82148
introduce mysqlConn.data
6629b93
@shogo82148
stop using buffer.takeSmallBuffer
f35e499
@shogo82148
stop using buffer.takeCompleteBuffer
56fe716
@shogo82148
Revert "introduce mysqlConn.data"
95e59e1 
This reverts commit 6629b93.
@shogo82148
revert changes of buffer.takeSmallBuffer
1b07946
@shogo82148
introduce mysqlConn.data
4ffc645
@shogo82148
re-implement mysqlConn.writeCommandPacket
dd65116
@shogo82148
re-implement mysqlConn.writeCommandPacketUint32
5c4569a
@shogo82148
remove buffer.takeSmallBuffer
8c475de
@shogo82148
remove buffer.store
b584ce9
@shogo82148
remove buffer.takeBuffer
366679e
@shogo82148
re-implement mysqlConn.readPacket
525a5a2
@shogo82148
fix race condition of read
832eeab
@shogo82148
mysqlConn.readFull supports context
6826f06
@shogo82148
mysqlConn.writePacket now supports context
5ed7b40
@shogo82148
mysqlConn.readPacket now supports context
d1c6fa0
@shogo82148
mysqlCon.handleAuthResult support context
6b20c77
@shogo82148
mysqlConn.handleInFileRequest supports context
e62a325
@shogo82148
mysqlConn.readHandshakePacket supports context
525ee4d
@shogo82148
mysqlConn.writeHandshakeResponsePacket supports context
20ce0ad
@shogo82148
mysqlConn.writeAuthSwitchPacket supports context
4274a48
@shogo82148
Revert "mysqlConn.readHandshakePacket supports context"
21c54fa 
This reverts commit 525ee4d.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 8, 2023
View reviewed changes
packets.go Fixed Show fixed Hide fixed
@coveralls
Copy link

coveralls commented Oct 8, 2023 •
edited

Coverage Status

coverage: 80.172% (-2.5%) from 82.713% when pulling 5bfa422 on shogo82148:introduce-reader-and-write-groutine-3 into 3798012 on go-sql-driver:master.

@shogo82148
Copy link
Contributor Author

It is too complex to maintain.

@shogo82148 shogo82148 closed this Dec 11, 2023
@shogo82148 shogo82148 deleted the introduce-reader-and-write-groutine-3 branch December 12, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shogo82148 @coveralls