Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring (*textRows).readRow in a more clear way #1230

Merged
merged 1 commit into from Jul 12, 2021

Commits on Jul 12, 2021

  1. refactoring (*textRows).readRow in a more clear way

    Fix error returns
    
    use utf8mb4 instead of utf8 in TestCharset (go-sql-driver#1228)
    
    From MySQL 8.0.24, `SELECT @@character_set_connection` reports utf8mb3 or utf8mb4 instead of utf8.
    Because utf8 is currently an alias for utf8mb3, however at some point utf8 is expected to become a reference to utf8mb4.
    
    > ref. https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-24.html#mysqld-8-0-24-bug
    > Important Note: When a utf8mb3 collation was specified in a CREATE TABLE statement, SHOW CREATE TABLE, DEFAULT CHARSET,
    > the values of system variables containing character set names,
    > and the binary log all subsequently displayed the character set as utf8 which is becoming a synonym for utf8mb4.
    > Now in such cases, utf8mb3 is shown instead, and CREATE TABLE raises the warning 'collation_name' is a collation of the deprecated character set UTF8MB3.
    > Please consider using UTF8MB4 with an appropriate collation instead. (Bug #27225287, Bug #32085357, Bug #32122844)
    >
    > References: See also: Bug #30624990.
    
    The document says that we should use utf8mb4 instead of utf8, so we should follow it.
    zihengCat committed Jul 12, 2021
    Copy the full SHA
    58f6c4a View commit details
    Browse the repository at this point in the history