Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move macOS CI from Travis to Actions #1182

Closed
wants to merge 3 commits into from
Closed

Move macOS CI from Travis to Actions #1182

wants to merge 3 commits into from

Conversation

methane
Copy link
Member

@methane methane commented Dec 23, 2020

Description

macOS test on Travis is not free for now. We will move all tests to Actions eventually but let's move macOS first.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane
Copy link
Member Author

methane commented Dec 23, 2020

See https://github.com/methane/mysql/runs/1598550834 for build log.

shogo82148
shogo82148 approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methane methane closed this Dec 23, 2020
@methane methane reopened this Dec 23, 2020
@julienschmidt
Copy link
Member

Was included in #1183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@methane @julienschmidt @shogo82148