Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor textRows.readRow to improve readability #1123

Closed
wants to merge 4 commits into from
Closed

Refactor textRows.readRow to improve readability #1123

wants to merge 4 commits into from

Commits on Jun 2, 2020

  1. Simplify textRows.readRow 

    Refactor textRows.readRow to improve readability:
* simplified flow:
  * reduced maximum indent level
  * return error early
  * remove 3 'continue'
* remove one type cast
* remove one obsolete comment about readLengthEncodedString
* -6 lines of code
    @dolmen
    dolmen committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    d4d83cc View commit details
    Browse the repository at this point in the history

  2. textRows.readRow: refactor for more early return style

    @dolmen
    dolmen committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    317d804 View commit details
    Browse the repository at this point in the history

  3. textRows.readRow: simplify switch block

    @dolmen
    dolmen committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    a4c7847 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. packets.go: add empty line for readability 

    Co-authored-by: Inada Naoki <songofacandy@gmail.com>
    @dolmen @methane
    dolmen and methane committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    5ea471c View commit details
    Browse the repository at this point in the history