Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: parse using byteslice in parseDateTime #1113

Merged
merged 11 commits into from May 31, 2020
Merged

utils: parse using byteslice in parseDateTime #1113

merged 11 commits into from May 31, 2020

Commits on May 26, 2020

  1. fixed the way of parsing datetime when byte slice string 

    The benchmark results

$ go test -benchmem . -bench "^BenchmarkParseByte"
goos: darwin
goarch: amd64
pkg: github.com/go-sql-driver/mysql
BenchmarkParseByteDateTime-4                    12023173               104 ns/op               0 B/op          0 allocs/op
BenchmarkParseByteDateTimeStringCast-4           3394239               355 ns/op              32 B/op          1 allocs/op
    @Code-Hex
    Code-Hex committed May 26, 2020
    Copy the full SHA
    ad990db View commit details
    Browse the repository at this point in the history

  2. added line to AUTHORS file

    @Code-Hex
    Code-Hex committed May 26, 2020
    Copy the full SHA
    5201e8a View commit details
    Browse the repository at this point in the history

  3. fixed error handling

    @Code-Hex
    Code-Hex committed May 26, 2020
    Copy the full SHA
    3a0b99c View commit details
    Browse the repository at this point in the history

  4. fixed nanosec digits

    @Code-Hex
    Code-Hex committed May 26, 2020
    Copy the full SHA
    128451e View commit details
    Browse the repository at this point in the history

  5. added more tests for error

    @Code-Hex
    Code-Hex committed May 26, 2020
    Copy the full SHA
    b7a5492 View commit details
    Browse the repository at this point in the history

  6. renamed parseByteDateTime to parseDateTime

    @Code-Hex
    Code-Hex committed May 26, 2020
    Copy the full SHA
    7ba45c5 View commit details
    Browse the repository at this point in the history

  7. reverted base null time

    @Code-Hex
    Code-Hex committed May 26, 2020
    Copy the full SHA
    c5a4dd2 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Update utils.go 

    Co-authored-by: Inada Naoki <songofacandy@gmail.com>
    @Code-Hex @methane
    Code-Hex and methane committed May 28, 2020
    Copy the full SHA
    9e639e4 View commit details
    Browse the repository at this point in the history

  2. Update utils.go 

    Co-authored-by: Inada Naoki <songofacandy@gmail.com>
    @Code-Hex @methane
    Code-Hex and methane committed May 28, 2020
    Copy the full SHA
    0e3cd50 View commit details
    Browse the repository at this point in the history

  3. Update utils.go 

    Co-authored-by: Inada Naoki <songofacandy@gmail.com>
    @Code-Hex @methane
    Code-Hex and methane committed May 28, 2020
    Copy the full SHA
    32ad982 View commit details
    Browse the repository at this point in the history

  4. removed deprecatedParseDateTime from test

    @Code-Hex
    Code-Hex committed May 28, 2020
    Copy the full SHA
    2c6aa27 View commit details
    Browse the repository at this point in the history