Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put zero filler into the SSL handshake packet. #1066

Merged
merged 1 commit into from Feb 25, 2020
Merged

Put zero filler into the SSL handshake packet. #1066

merged 1 commit into from Feb 25, 2020

Commits on Feb 24, 2020

  1. Put zero filler into the SSL handshake packet. 

    According to the linked documentation at
http://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::SSLRequest
SSLRequest packet should have zero filler similar to the regular handshake request,
but now the driver puts zeros only in the regular request. Luckily vanilla MySQL
doesn't rely on this zero filler and doesn't verify its presence, thus the driver worked
fine so far. But MySQL can change to rely on zeros at any point.

The problem was discovered while testing against a customized MySQL.
    @pivanof
    pivanof committed Feb 24, 2020
    Copy the full SHA
    15817aa View commit details
    Browse the repository at this point in the history