Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension to help use LOAD DATA LOCAL INFILE #1060

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noborus
Copy link
Contributor

@noborus noborus commented Feb 13, 2020

Description

Allows data to be imported by Exec(parameter) after using
special Data::Data as file path of LOAD DATA LOCAL INFILE.
It is easy to use instead of INSERT INTO.

This is easier to import than io.Reader
when you want to import data generated from the program.

Implementation method.

  1. Add the LOAD DATA flag to Prepare() and Exec().
  2. Exec() with LOAD DATA flag set will send the parameter converted to TSV.

Sorry for the big patch.
I don't think this is a change that everyone agrees with.
I would like to ask you if such an extension is acceptable.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Allows data to be imported by Exec(parameter) after using
special `Data::Data` as file path of `LOAD DATA LOCAL INFILE`.
It is easy to use instead of `INSERT INTO`.

This is easier to import than io.Reader
when you want to import data generated from the program.

Implementation method.

1. Add the `LOAD DATA` flag to Prepare() and Exec().
2. Exec() with `LOAD DATA` flag set will send the parameter converted to TSV.
@methane
Copy link
Member

methane commented Feb 13, 2020

I don't like this design. My rough idea is:

// signature
mysql.LoadLocalInfile(conn sql.Conn, query string, file io.Reader)

// usage
import (
    "database/sql"
    "github.com/go-sql-driver/mysql"
)
// ...
conn := db.Conn()
err := mysql.LoadLocalInfile(conn, "LOAD LOCAL INFILE ... ", string.Reader(data))
// ...

As of Go 1.13, Conn.Raw is added.
LoadLocalInfile can be implemented using it.

@noborus
Copy link
Contributor Author

noborus commented Feb 13, 2020

I don't like this design. My rough idea is:

I understand what you say.

LoadLocalInfile can be implemented using it.

Yes. I think it is good.

However, the io.Reader interface is not easy to handle the large stream data generated.
I wanted a mechanism to help that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants