Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile error of connCheck.go #1048

Merged
merged 2 commits into from Jan 5, 2020
Merged

fix compile error of connCheck.go #1048

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceed4d4
fix compile error of connCheck.go
shogo82148 Jan 5, 2020
225bd12
remove "appengine" build tag
shogo82148 Jan 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion conncheck.go
View file
Open in desktop
Expand Up @@ -6,7 +6,8 @@
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// You can obtain one at http://mozilla.org/MPL/2.0/.

// +build !windows,!appengine
// +build linux darwin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connCheck may work unix-like OSs (e.g. aix, dragonfly, freebsd, netbsd, openbsd, solaris), but I'm not sure.
can anyone check it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least it cross-compiles. I would add them there as well

// +build !appengine

package mysql

Expand Down
2 changes: 1 addition & 1 deletion conncheck_dummy.go
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// You can obtain one at http://mozilla.org/MPL/2.0/.

// +build windows appengine
// +build !linux,!darwin appengine

package mysql

Expand Down
3 changes: 2 additions & 1 deletion conncheck_test.go
View file
Open in desktop
Expand Up @@ -6,7 +6,8 @@
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// You can obtain one at http://mozilla.org/MPL/2.0/.

// +build go1.10,!windows
// +build linux darwin
// +build !appengine

package mysql

Expand Down