Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile error of connCheck.go #1048

Merged
merged 2 commits into from Jan 5, 2020
Merged

fix compile error of connCheck.go #1048

merged 2 commits into from Jan 5, 2020

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Jan 5, 2020 •
edited

Description

fix compile error of connCheck.go on plan9

ref. #1047 (comment)

$ GOOS=plan9 GOARCH= amd64 go build github.com/go-sql-driver/mysql
# github.com/go-sql-driver/mysql
./conncheck.go:42:15: undefined: syscall.EAGAIN
./conncheck.go:42:40: undefined: syscall.EWOULDBLOCK

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

shogo82148
shogo82148 commented Jan 5, 2020
View reviewed changes
conncheck.go
@@ -6,7 +6,8 @@
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// You can obtain one at http://mozilla.org/MPL/2.0/.

// +build !windows,!appengine
// +build linux darwin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connCheck may work unix-like OSs (e.g. aix, dragonfly, freebsd, netbsd, openbsd, solaris), but I'm not sure.
can anyone check it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least it cross-compiles. I would add them there as well

@methane
Copy link
Member

methane commented Jan 5, 2020

I think we can drop the deprecated "appengine" build tag because we dropped Go 1.9 already.

@shogo82148
Copy link
Contributor Author

I see
I removed the "appengine" build tag.

@shogo82148 shogo82148 merged commit 8723940 into go-sql-driver:master Jan 5, 2020
@shogo82148 shogo82148 deleted the fix-compile-error-on-plan9 branch January 5, 2020 05:18
@shogo82148
Copy link
Contributor Author

merged. thanks!

@julienschmidt julienschmidt added this to the v1.5.0 milestone Jan 5, 2020
@julienschmidt julienschmidt mentioned this pull request Jan 6, 2020
Merged
5 tasks
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@shogo82148 @tz70s
fix compile error of connCheck.go (go-sql-driver#1048)
13572bb 
* fix compile error of connCheck.go

* remove "appengine" build tag
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@shogo82148 @tz70s
fix compile error of connCheck.go (go-sql-driver#1048)
43b3352 
* fix compile error of connCheck.go

* remove "appengine" build tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienschmidt julienschmidt julienschmidt left review comments

@methane methane methane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shogo82148 @methane @julienschmidt