Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cloudsql dialer #1007

Merged
merged 1 commit into from Oct 1, 2019
Merged

remove cloudsql dialer #1007

merged 1 commit into from Oct 1, 2019

Conversation

julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented Sep 30, 2019 •
edited

CloudSQL is only available up to Go 1.9 on Google AppEngine, which was phased out. Starting from 2019-10-01, no new apps can be deployed to GAE/Go 1.9 anymore. This dialer is thus obsolete.

Fixes #1002

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt julienschmidt added this to the v1.5.0 milestone Sep 30, 2019
@julienschmidt julienschmidt merged commit 59de189 into master Oct 1, 2019
@julienschmidt julienschmidt deleted the cloudsql branch October 1, 2019 06:08
@jsha jsha mentioned this pull request Nov 14, 2019
Closed
@mpolden mpolden mentioned this pull request Jan 14, 2020
Closed
@arp242 arp242 mentioned this pull request Feb 1, 2020
Closed
5 tasks
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@julienschmidt @tz70s
Remove Cloud SQL dialer (go-sql-driver#1007)
474e21a 
CloudSQL is only available up to Go 1.9 on Google AppEngine, which was phased out. Starting from 2019-10-01, no new apps can be deployed to GAE/Go 1.9 anymore. This dialer is thus obsolete.

Fixes go-sql-driver#1002
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@julienschmidt @tz70s
Remove Cloud SQL dialer (go-sql-driver#1007)
45fc137 
CloudSQL is only available up to Go 1.9 on Google AppEngine, which was phased out. Starting from 2019-10-01, no new apps can be deployed to GAE/Go 1.9 anymore. This dialer is thus obsolete.

Fixes go-sql-driver#1002
@denbeigh2000 denbeigh2000 mentioned this pull request Feb 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
cloudsql
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Remove cloudsql support
2 participants
@julienschmidt @methane