Skip to content

Commit

Permalink
report SQLState in MySQLError
Browse files Browse the repository at this point in the history
to allow library users to distinguish user-defined from client / server errors
  • Loading branch information
thopos committed Apr 6, 2022
1 parent a0b5ef3 commit 14893f1
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 7 deletions.
15 changes: 13 additions & 2 deletions errors.go
Expand Up @@ -56,11 +56,15 @@ func SetLogger(logger Logger) error {

// MySQLError is an error type which represents a single MySQL error
type MySQLError struct {
Number uint16
Message string
Number uint16
SQLState string
Message string
}

func (me *MySQLError) Error() string {
if me.SQLState != "" {
return fmt.Sprintf("Error %d (%s): %s", me.Number, me.SQLState, me.Message)
}
return fmt.Sprintf("Error %d: %s", me.Number, me.Message)
}

Expand All @@ -70,3 +74,10 @@ func (me *MySQLError) Is(err error) bool {
}
return false
}

func (me *MySQLError) IsWithSQLState(err error) bool {
if merr, ok := err.(*MySQLError); ok {
return merr.Number == me.Number && merr.SQLState == me.SQLState
}
return false
}
19 changes: 16 additions & 3 deletions errors_test.go
Expand Up @@ -43,13 +43,13 @@ func TestErrorsStrictIgnoreNotes(t *testing.T) {
}

func TestMySQLErrIs(t *testing.T) {
infraErr := &MySQLError{1234, "the server is on fire"}
otherInfraErr := &MySQLError{1234, "the datacenter is flooded"}
infraErr := &MySQLError{1234, "", "the server is on fire"}
otherInfraErr := &MySQLError{1234, "", "the datacenter is flooded"}
if !errors.Is(infraErr, otherInfraErr) {
t.Errorf("expected errors to be the same: %+v %+v", infraErr, otherInfraErr)
}

differentCodeErr := &MySQLError{5678, "the server is on fire"}
differentCodeErr := &MySQLError{5678, "", "the server is on fire"}
if errors.Is(infraErr, differentCodeErr) {
t.Fatalf("expected errors to be different: %+v %+v", infraErr, differentCodeErr)
}
Expand All @@ -59,3 +59,16 @@ func TestMySQLErrIs(t *testing.T) {
t.Fatalf("expected errors to be different: %+v %+v", infraErr, nonMysqlErr)
}
}

func TestMySQLErrIsWithSQLState(t *testing.T) {
infraErr := &MySQLError{1234, "HY000", "the server is on fire"}
otherInfraErr := &MySQLError{1234, "HY000", "the datacenter is flooded"}
if !infraErr.IsWithSQLState(otherInfraErr) {
t.Errorf("expected errors to be the same: %+v %+v", infraErr, otherInfraErr)
}

differentCodeErr := &MySQLError{1234, "42000", "the server is on fire"}
if infraErr.IsWithSQLState(differentCodeErr) {
t.Fatalf("expected errors to be different: %+v %+v", infraErr, differentCodeErr)
}
}
5 changes: 3 additions & 2 deletions packets.go
Expand Up @@ -599,8 +599,9 @@ func (mc *mysqlConn) handleErrorPacket(data []byte) error {

// Error Message [string]
return &MySQLError{
Number: errno,
Message: string(data[pos:]),
Number: errno,
SQLState: sqlstate,
Message: string(data[pos:]),
}
}

Expand Down

0 comments on commit 14893f1

Please sign in to comment.